Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning if bidCpmAdjustment is set for AOL bidder #725

Closed
marian-r opened this issue Oct 19, 2016 · 5 comments · Fixed by c1x/Prebid.js#1
Closed

Show warning if bidCpmAdjustment is set for AOL bidder #725

marian-r opened this issue Oct 19, 2016 · 5 comments · Fixed by c1x/Prebid.js#1
Assignees
@marian-r
Labels
feature

Comments

@marian-r
Copy link
Member

Type of issue

Suggestion

Description

After the recent update of AOL adapter made in #653, the bid price adjustment is not possible on the client side and it has been moved onto backend. In the PR I suggested a note to be included in the release notes, but I expect that can be not enough and some publishers may over look that.

So, I would suggest showing a warning in the console if the publisher has configured bidCpmAdjustment, saying something like:

Warning: bidCpmAdjustment is active for the AOL adapter. As of Prebid 0.14, AOL bids may already be in net – please contact your accounts team to confirm.

This will help publishers to prevent potential issues after the upgrade.

@mkendall07 @matthewlane what do you think?

We are more than happy to create a PR asap for it to be included in 0.14.0, but I just wanted to check first.
@mkendall07
Copy link
Member

@marian-r
Feel free to submit the PR. I think you have time to include it into 0.14.0. We are targeting end of the month release. Thanks

@marian-r
Copy link
Member Author

Awesome, thanks 👍

@mkendall07
Copy link
Member

@marian-r
Can you drop me an email, I have a question that is unrelated to this change. You can find my email in my profile. Thanks!

marian-r added a commit to aol/Prebid.js that referenced this issue Oct 20, 2016
@marian-r
Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid…
c5e7378 
…#725)
@marian-r marian-r mentioned this issue Oct 20, 2016
Merged
1 task
@dugwood
Copy link
Contributor

dugwood commented Oct 22, 2016

Seems dangerous to me: this forbids the floor price principle. If you can't set a floor price in AOL backend, then you can't say «I don't want bids under $X.XX» by returning a zero value.

@mkendall07
Copy link
Member

@dugwood
It's just a warning displayed. It can still be used.

@jpteam jpteam mentioned this issue Oct 26, 2016
Merged
9 tasks
jpteam added a commit to c1x/Prebid.js that referenced this issue Oct 26, 2016
@jpteam
Merge pull request #1 from prebid/master
a6be2a0 
Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) …
mp-12301 pushed a commit to aol/Prebid.js that referenced this issue Apr 10, 2017
Merge pull request prebid#51 in AOLP_ADS_JS/prebid.js from feature/Pr…
262f371 
…ebid-0.14.0 to release/1.7.0

* commit '3eefcf043466f5457c81bfec18b032b53490b78b': (52 commits)
  New adapters ids.
  Prebid 0.14.0 Release
  add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763)
  Add pbjs.getHighestCpmBids for getting winning bids (prebid#755)
  Fix build
  Drop Sekindo adapter.
  Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758)
  amp integration (prebid#756)
  Add contribution guidelines (prebid#761)
  Add api method to shuffle the order bidders are called in (prebid#760)
  build adapter from custom source path (prebid#753)
  reduce duplication and ignore ga.js in coverage (prebid#754)
  Log /ut response errors in dev console (prebid#747)
  Fix indentation (code style error when building) (prebid#751)
  Add package keywords (prebid#746)
  added new rubiconLite adapter (prebid#740)
  Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728)
  IX adapter code refactoring (prebid#711)
  Update memeglobal.js (prebid#737)
  Pulsepoint Analytics adapter for Prebid (prebid#706)
  ...
mp-12301 pushed a commit to aol/Prebid.js that referenced this issue Apr 10, 2017
Merge pull request prebid#54 in AOLP_ADS_JS/prebid.js from release/1.…
a3ee191 
…7.0 to master

* commit '262f371a5c855419c3ef357fb1f0cf87a107749f': (52 commits)
  New adapters ids.
  Prebid 0.14.0 Release
  add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763)
  Add pbjs.getHighestCpmBids for getting winning bids (prebid#755)
  Fix build
  Drop Sekindo adapter.
  Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758)
  amp integration (prebid#756)
  Add contribution guidelines (prebid#761)
  Add api method to shuffle the order bidders are called in (prebid#760)
  build adapter from custom source path (prebid#753)
  reduce duplication and ignore ga.js in coverage (prebid#754)
  Log /ut response errors in dev console (prebid#747)
  Fix indentation (code style error when building) (prebid#751)
  Add package keywords (prebid#746)
  added new rubiconLite adapter (prebid#740)
  Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728)
  IX adapter code refactoring (prebid#711)
  Update memeglobal.js (prebid#737)
  Pulsepoint Analytics adapter for Prebid (prebid#706)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marian-r marian-r

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show warning if bidCpmAdjustment is set for AOL bidder (closes #725) … prebid/Prebid.js
3 participants
@mkendall07 @marian-r @dugwood