-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT [Weborama RTD Submodule] Fix appnexus implementation #10113
Conversation
The way you have this set up is a rules violation; please inspect 1plusX and Airgrid. I registered a segment taxonomy with the IAB on your behalf. If you write to segments, appnexus can pick them up now in 8.0 Thanks! |
Sorry, I am a little bit lost: what is the rule violation that I am doing here? Perhaps I lost something from the comments on the previous MR #10005 |
BTW if the correct development is just remove any code that handles |
Yes, please don't reference bid adapters in the module. However, feel free to append to this so appnexus picks up your segments
|
@peczenyj is this ready? Our goal here isn't to break your integration with any bidder, it's to move the handling so publisher data controls are not bypassed when publishers attempt to suppress parts of the bids request object using data or activity control features. Are you satisfied this achieves that goal? If not, we're committed to assist |
To be honest, this is ready if Appnexus is ready to use the ortb2Fragment. I think it is not the case, based on the previous merge request #10005 |
@dgirardi @jsnellbaker any thoughts on how to push forward here? we'd love to restore all functionality |
hello @patmmccann @dgirardi and @jsnellbaker I was revisiting this subject, but after a long time I must rewind it to the begining and start again. It seems the options for weborama here are:
It seems the options for appnexus here are:
From our side we start to talk about the possible solutions 1 and/or 2. Regards |
Option 1 seems quite workable, and has been accomplished by others. Why not persue that? |
closing as stale, feel free to resubmit |
Type of change
Description of change
This Pull Requests finish the work started on #10005
Here we:
site.content.keywords
oruser.keywords
using the formatkey=foo,key=bar,...
appnexus
to use it as a default value. Other aliases can be added via configurationToday we check for appnexus and registered aliases and we don't want to remove this behavior without warn all of our customers. We plan some modifications to do in the next releases to avoid break backward compatibility.