-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preciso Bid adapter : Initial release #10138
Conversation
We would expect to see your endpoint return bids when testing using the local environment within the prebid.js repo. After the recent updates and using the parameters in your markdown file, I am currently I'm seeing CORS errors on your AD_URL endpoint |
Checked back in, I am still seeing a CORS error from your endpoint when testing with the supplied params and endpoint from this PR. Could you please look into updating your server so it returns a valid bid to complete my testing? Thank you |
Thank you for updating me. Currently, we are working on fixing the issue. As soon as it is completed, we will update here. |
On the particular server, we deployed our bidder application. Would you mind testing again? |
@PrecisoSRL Looks like there is still a CORS error. To test on your end, you can run a |
thank you for updating me. we will check and fix the issue as soon as possible |
@PrecisoSRL Seeing a 204 now, which is good progress. Now can you make sure your example params in your markdown file return test responses for these specific params? The expectation is that a User can try out your adapter and see it working in the their Prebid auction. We'd like to see this before we can move forward with approving the PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information