Qortex RTD Provider: add module to submodules.json #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisHuie @Rothalack Hi all, just looping in those who have reviewed our code recently. Our release did not include submodules.json, so our module is not downloading with rtdModule attached. I'm not sure what could be causing this error in testing, please advise if possible thank you |
ChrisHuie
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After our code was merged, we realized that this file was missing from the PR. In its current state, the download page does not add the required rtdModule into the generated prebid build, leading to errors when implemented on publisher pages.
Please advise if this should resolve the issue and thank you for the help!