-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter bug fix #1096
Merged
Merged
Adapter bug fix #1096
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
c4367bc
Added WideOrbit adapter
bjorn-wo 19ea04d
Merge branch 'master' of https://github.com/prebid/Prebid.js
bjorn-wo 1dc879e
Fix User Matching code
bjorn-wo 428ca07
update repo from prebid.js
bjorn-wo cd0b8ed
Renamed adapter + some minor JS issues
bjorn-wo 6dc3198
Added flag for notifying front action is header bidding. Use returned…
bjorn-wo cf5e0cc
Merge remote-tracking branch 'upstream/master'
bjorn-wo 4dbe270
Duplicated properties fixed.
bjorn-wo b21ef42
Correcting adaptermanager after wrong merge. Now all tests passes cor…
32289dc
Seting fl and jscb directly in the pageImpression-part of the url, si…
df7486e
Fixed above the fold parameter
bjorn-wo 3f8a403
No need to modify original value.
4a0d1f7
Normalizing file regarding single or double quotes. Also, properly in…
82506d9
Removed uneeded properties: referrer (twice) and tagId.
82ef76a
Slightly better readiblity for variable declarations (and definition …
5e1d7ed
Refactoring regarding function naming and the way we set rank parameter.
646804c
Ignoring TypeScript's typing definitions.
bbd3ebb
Added initial WideOrbit Adapter tests covering url-creation part.
c6e876e
Completed wide orbit adapter tests with the one regarding callback re…
69a86e0
Slightly better test names.
35d52e6
Fix support for already prepared tracking pixels
bjorn-wo ac2b698
Merge remote-tracking branch 'upstream/master'
bjorn-wo 4e3c0ea
Modified indenting according to coding standard
bjorn-wo a96ff78
Code review fixes
bjorn-wo f832b26
Marked required parameters
bjorn-wo 584f4ab
Merge remote-tracking branch 'upstream/master'
bjorn-wo a93636a
Remove unused library from package.json
bjorn-wo f397076
Fix conflict with package.json
bjorn-wo d5e6a80
Merge remote-tracking branch 'upstream/master'
bjorn-wo c00bf75
Added support for referrer
bjorn-wo 79dc0f1
Added support for referrer
bjorn-wo bb41f0f
Merge branch 'master' of https://github.com/WideOrbit/Prebid.js
bjorn-wo 15b867f
Updated line endings to UNIX style
bjorn-wo 74545b0
Fixed formatting issue
bjorn-wo feb789c
Fix user matching identification for JavaScript type
bjorn-wo b440566
Merge remote-tracking branch 'upstream/master'
bjorn-wo cfac6a7
Duplicated WideOrbit spec after merge
bjorn-wo b421e4b
Made adapter more robust for server misconfiguration
bjorn-wo c5b7abb
Merge remote-tracking branch 'upstream/master'
bjorn-wo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you assert that
addBidResponse
wasn't invoked here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will actually call addBidResponse. It will however not throw an exception as it did before. I agree the test isn't very good, but it did catch my particular issue.