-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemantIQ RTD Provider: initial release #12668
SemantIQ RTD Provider: initial release #12668
Conversation
d958dd2
to
81af548
Compare
@alexandr-kim-vl we have fixed the build error in the current version of master if you bring in recent commits |
81af548
to
98878e3
Compare
Hi, In your doc, you specify that the To optimize the byte usage for each request, consider the following suggestions:
Let me know, otherwise LGTM. |
98878e3
to
5126a33
Compare
Hi @osazos! Thank you for the review and recommendations.
You're right, marked it as optional.
I removed the keywords with no value and adjusted the tests, it shouldn't make any difference.
This format is chosen because it's the only way to pass an array of values to the appnexusBidAdapter, and Xandr is our main partner right now. But I'll keep an eye on what format the other bidders use and may come up with a more optimal option. |
@alexandr-kim-vl, did you plan to add a doc in https://github.com/prebid/prebid.github.io? You should add it asap to be able to merged. |
@osazos wanted to wait for feedback before creating it: prebid/prebid.github.io#5904 |
Add a comment for that in the doc PR plz. |
@osazos I meant feedback on the module PR, the documentation is now ready, thanks again for checking. |
Type of change
Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
SemantIQ RTD Provider: initial release prebid.github.io#5904
Description of change
Adding a new RTD submodule that receives targeting data from the SemantIQ service and populates
ortb2Fragments
.Maintainer: [email protected]
Module configuration