Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemantIQ RTD Provider: initial release #12668

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

alexandr-kim-vl
Copy link
Contributor

@alexandr-kim-vl alexandr-kim-vl commented Jan 17, 2025

Type of change

Description of change

Adding a new RTD submodule that receives targeting data from the SemantIQ service and populates ortb2Fragments.

Maintainer: [email protected]

Module configuration

  pbjs.setConfig({
    ...
    realTimeData: {
      dataProviders: [
        {
          name: 'semantiq',
          waitForIt: true,
          params: {
            companyId: 12345,
            timeout: 1000,
          },
        },
      ],
    },
  });

@alexandr-kim-vl alexandr-kim-vl marked this pull request as draft January 22, 2025 02:18
@alexandr-kim-vl alexandr-kim-vl force-pushed the feature/semantiqRtdProvider branch 2 times, most recently from d958dd2 to 81af548 Compare January 22, 2025 10:33
@alexandr-kim-vl alexandr-kim-vl marked this pull request as ready for review January 22, 2025 11:09
@ChrisHuie ChrisHuie requested a review from osazos January 24, 2025 15:29
@ChrisHuie
Copy link
Collaborator

@alexandr-kim-vl we have fixed the build error in the current version of master if you bring in recent commits

@alexandr-kim-vl alexandr-kim-vl force-pushed the feature/semantiqRtdProvider branch from 81af548 to 98878e3 Compare January 24, 2025 15:34
@osazos
Copy link
Collaborator

osazos commented Feb 20, 2025

Hi,

In your doc, you specify that the companyId is required. However, there is no mechanism to ensure that it has been set, and providing feedback on this could be beneficial.

To optimize the byte usage for each request, consider the following suggestions:

  • Currently, you set a none string when there is no value for a keyword. Would it be acceptable to simply omit the keyword altogether, or does none hold specific significance for your customers?
  • You duplicate the keyword for each value, e.g., ctx_segment=C001,ctx_segment=C002. Could it be an option to consolidate these into a single keyword with concatenated values, such as ctx_segment=C001|C002? I am unsure of the actual usage, so this suggestion might not be applicable.

Let me know, otherwise LGTM.

@alexandr-kim-vl alexandr-kim-vl force-pushed the feature/semantiqRtdProvider branch from 98878e3 to 5126a33 Compare February 21, 2025 06:50
@alexandr-kim-vl
Copy link
Contributor Author

Hi @osazos!

Thank you for the review and recommendations.

In your doc, you specify that the companyId is required. However, there is no mechanism to ensure that it has been set, and providing feedback on this could be beneficial.

You're right, marked it as optional.

Currently, you set a none string when there is no value for a keyword. Would it be acceptable to simply omit the keyword altogether, or does none hold specific significance for your customers?

I removed the keywords with no value and adjusted the tests, it shouldn't make any difference.

You duplicate the keyword for each value, e.g., ctx_segment=C001,ctx_segment=C002. Could it be an option to consolidate these into a single keyword with concatenated values, such as ctx_segment=C001|C002? I am unsure of the actual usage, so this suggestion might not be applicable.

This format is chosen because it's the only way to pass an array of values to the appnexusBidAdapter, and Xandr is our main partner right now. But I'll keep an eye on what format the other bidders use and may come up with a more optimal option.

@osazos
Copy link
Collaborator

osazos commented Feb 21, 2025

@alexandr-kim-vl, did you plan to add a doc in https://github.com/prebid/prebid.github.io? You should add it asap to be able to merged.

@alexandr-kim-vl
Copy link
Contributor Author

alexandr-kim-vl commented Feb 21, 2025

@alexandr-kim-vl, did you plan to add a doc in https://github.com/prebid/prebid.github.io? You should add it asap to be able to merged.

@osazos wanted to wait for feedback before creating it: prebid/prebid.github.io#5904

@osazos osazos removed the needs docs label Feb 21, 2025
@osazos
Copy link
Collaborator

osazos commented Feb 21, 2025

@osazos wanted to wait for feedback before creating it: prebid/prebid.github.io#5904

Add a comment for that in the doc PR plz.

@osazos osazos merged commit 866b18e into prebid:master Feb 21, 2025
6 checks passed
@alexandr-kim-vl
Copy link
Contributor Author

@osazos wanted to wait for feedback before creating it: prebid/prebid.github.io#5904

Add a comment for that in the doc PR plz.

@osazos I meant feedback on the module PR, the documentation is now ready, thanks again for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants