Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharethrough Adapter - set bidderCode on invalid bid #1295

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Sharethrough Adapter - set bidderCode on invalid bid #1295

merged 1 commit into from
Aug 28, 2017

Conversation

jchau87
Copy link
Contributor

@jchau87 jchau87 commented Jun 15, 2017

Type of change

  • Bugfix
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Description of change

  • Set bidderCode on bid object for invalid bids
  • Don't use exception handling for control flow when there are no creatives

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    [email protected]
  • official adapter submission

@ndhimehta ndhimehta assigned snapwich and unassigned ndhimehta Jun 16, 2017
@snapwich
Copy link
Collaborator

LGTM 👍

@snapwich snapwich self-requested a review June 19, 2017 21:40
snapwich
snapwich previously approved these changes Jun 19, 2017
View reviewed changes
@dbemiller
Copy link
Contributor

@jchau87 Please fix the merge conflicts, and update for compatibility with #1177

@dbemiller dbemiller removed the LGTM label Jul 26, 2017
@mkendall07
Copy link
Member

mkendall07 commented Aug 15, 2017 •
edited
Loading

@jchau87 still waiting to resolve conflicts to merge this.

Specifically you need to move your adapter code into /modules directory.

@strworkstation strworkstation force-pushed the jc/set-bidder-code-for-invalid-bid branch from d1da910 to ed6ba40 Compare August 18, 2017 20:29
@jchau87
Copy link
Contributor Author

jchau87 commented Aug 18, 2017 •
edited
Loading

Rebased with master which moved Sharethrough adapter moved into /modules directory

@jaiminpanchal27 jaiminpanchal27 self-requested a review August 28, 2017 14:08
@jaiminpanchal27 jaiminpanchal27 merged commit 4c8ba54 into prebid:master Aug 28, 2017
ptomasroos pushed a commit to happypancake/Prebid.js that referenced this pull request Sep 1, 2017
@jchau87 @ptomasroos
Sharethrough Adapter - set bidderCode on invalid bid (prebid#1295)
7064779
@jchau87 jchau87 deleted the jc/set-bidder-code-for-invalid-bid branch September 6, 2017 20:41
philipwatson pushed a commit to mbrtargeting/Prebid.js that referenced this pull request Sep 18, 2017
@jchau87 @philipwatson
Sharethrough Adapter - set bidderCode on invalid bid (prebid#1295)
1161e13
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
@jchau87 @jbAdyoulike
Sharethrough Adapter - set bidderCode on invalid bid (prebid#1295)
7d9878e
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@jchau87 @dluxemburg
Sharethrough Adapter - set bidderCode on invalid bid (prebid#1295)
918deab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@snapwich snapwich snapwich left review comments

Assignees

@snapwich snapwich

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jchau87 @snapwich @dbemiller @mkendall07 @jaiminpanchal27 @matthewlane @ndhimehta