Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPM value as parameter for Vertoz Adapter #1306

Merged
merged 4 commits into from
Jul 17, 2017
Merged

Added CPM value as parameter for Vertoz Adapter #1306

merged 4 commits into from
Jul 17, 2017

Conversation

Prebid-Vertoz
Copy link
Contributor

Type of change

  • [x ] Other

Description of change

Addition of CPM value as a parameter in Vertoz Adapter.

Other information

@Prebid-Vertoz
Copy link
Contributor Author

Hi team,

Just to ensure, is anything more needs to be done from our side?

@mkendall07
Copy link
Member

@Prebid-Vertoz
Please rebase off master as the adapters are now under /modules instead of /src/adapters

@Prebid-Vertoz
Copy link
Contributor Author

@mkendall07 Thanks for your reply.
I have done changes now.

@@ -20,6 +20,7 @@ function VertozAdapter() {
let vzEndPoint = BASE_URI;
let reqParams = bid.params || {};
let placementId = utils.getValue(reqParams, 'placementId');
let cpm = utils.getValue(reqParams, 'cpm');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is cpm suppose to represent? Is this a floor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a floor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename it to cpmFloor or similar than?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mkendall07 , renamed cpm to cpmFloor.

@mkendall07 mkendall07 merged commit 2c8ec16 into prebid:master Jul 17, 2017
@mkendall07
Copy link
Member

this is merged. Please update the documentation page as well. Thanks

@Prebid-Vertoz
Copy link
Contributor Author

Hi @mkendall07 we have updated documentation page for this change and placed a pull request.
But we could not see our change reflected when we downloaded prebid.js from download page with only vertoz adapter selected.

@mkendall07
Copy link
Member

It will be released next week when we update the download page.

outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Jul 28, 2017
…built

* 'master' of https://github.com/prebid/Prebid.js: (95 commits)
  Specify --browsers when using gulp test --watch (prebid#1420)
  Added aliases for aol adapter. (prebid#1371)
  Added MobFox Adapter (prebid#1312)
  Fixed style error. (prebid#1419)
  Add native support for Criteo adapter (prebid#999)
  Update admediaBidAdapter.js (prebid#1395)
  Increment pre version (prebid#1413)
  Prebid 0.26.1 Release (prebid#1412)
  fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411)
  Lint modules directory (prebid#1404)
  Set outstream mediaType based on renderer in response (prebid#1391)
  Fixing the BidAdjustmentEvent fire time (prebid#1399)
  Fix banner showing up in prebid-core.js (prebid#1388)
  Mention NodeJS 4.0 dependency in the README (prebid#1386)
  Increment pre version (prebid#1385)
  Prebid 0.26.0 Release (prebid#1384)
  PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383)
  Modernizing build dependencies (prebid#1355)
  StickyAdsTV bidder adapter update (prebid#1311)
  Added CPM value as parameter for Vertoz Adapter (prebid#1306)
  ...
@Prebid-Vertoz
Copy link
Contributor Author

Hi @mkendall07 , is that download page updated. Actually we still can not see our change reflected when we downloaded prebid.js with vertoz adapter.

@Prebid-Vertoz
Copy link
Contributor Author

Hi @mkendall07 , any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants