add option to run tests in a specific file #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
suggested changes
Oct 23, 2017
karma.conf.maker.js
Outdated
| var webpackConfig = newWebpackConfig(codeCoverage); | ||
| var plugins = newPluginsArray(browserstack); | ||
| var files = [ | ||
| var files = file ? [file] : [ |
There was a problem hiding this comment.
I think this needs to be var files = file ? ['test/helpers/prebidGlobal.js', file] : ...
Otherwise it fails on files which use $$PREBID_GLOBAL$$--even if it's just indirectly, through the import chain. For example, gulp test --file "test/spec/modules/appnexusAstBidAdapter_spec.js" fails because the adapter relies on src/config, which relies on $$PREBID_GLOBAL$$.
This problem should fade away as progress gets made on #1508 and #1510... but for now it's common enough that the gulpfile should probably support it.
| // If --browserstack is given, it will run the full suite of currently supported browsers. | ||
| // If --browsers is given, browsers can be chosen explicitly. e.g. --browsers=chrome,firefox,ie9 | ||
| gulp.task('test', ['clean'], function (done) { | ||
| var karmaConf = karmaConfMaker(false, argv.browserstack, argv.watch); | ||
| var karmaConf = karmaConfMaker(false, argv.browserstack, argv.watch, argv.file); |
There was a problem hiding this comment.
Could you also add this to the test-coverage task?
|
@dbemiller thanks for the review! I have committed the changes. |
dbemiller
approved these changes
Oct 24, 2017
mkendall07
approved these changes
Oct 24, 2017
Merged
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 25, 2017
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When developing an adapter, I don't need to run the whole test suite, it's very time consuming. This PR adds an option to run a specific test file. Usage: