Optimera Adapter for 1.0 (#1759) #1760

mcallari · 2017-10-24T15:27:28Z

Type of change

New bidder adapter

Type of issue

Feature Request

Description

Adding Optimera's bid adapter for public use. Optimera's technology allows publishers to target viewability data to automate viewability optimization for any line item or PMP. Optimera does not push bids but instead targeting data via the deal ID space.

test parameters for validating bids

Optimera will pass targeting data via hb_deal_optimera, will never pass a size therefore 0x0, will never pass a price therefore 0.00. For example:
hb_deal_optimera=RB_K,300x250K,300x600K&hb_size_optimera=0x0&hb_pb_optimera=0.00&hb_adid_optimera=86a7b6905fe174&hb_bidder_optimera=optimera

{
  bidder: 'optimera',
  params: {
    custom: {
      clientId: '1234'
    }
  }
}

An external lib is needed and can be added to the site's footer:

<script src="https://s3.amazonaws.com/elasticbeanstalk-us-east-1-397719490216/external_json/oPS.js"></script>

contact email of the adapter’s maintainer
[email protected]

official adapter submission

Other information

Test Page:
http://optimera.elasticbeanstalk.com/prebidDemoPage.php
@kcandiotti

Relates to PR: #1617

snapwich · 2017-10-31T20:26:06Z

test/spec/modules/optimeraBidAdapter_spec.js

+      }
+    ];
+    it('buildRequests fires', () => {
+      var request = spec.buildRequests(validBidRequests);


You appear to be missing some assertions

snapwich · 2017-10-31T20:28:47Z

modules/optimeraBidAdapter.js

+   * @return boolean True if this is a valid bid, and false otherwise.
+   */
+  isBidRequestValid: function (bidRequest) {
+    return !!(bidRequest.params.custom.clientID);


This will throw an exception custom.clientID is not present. Should do safe evaluation, isBidRequestValid should not throw.

snapwich · 2017-10-31T20:30:53Z

modules/optimeraBidAdapter.js

+    var timestamp = Math.round(new Date().getTime() / 1000);
+    var clientID = validBidRequests[0].params.custom.clientID;
+    var oDv = [];
+    if (clientID != undefined) {


preferred method for undefined check in javascript is if (typeof clientID !== 'undefined') {

snapwich · 2017-10-31T20:31:45Z

modules/optimeraBidAdapter.js

+    if (clientID != undefined) {
+      oDv.push(clientID);
+      for (var i = 0; i < validBidRequests.length; i++) {
+        oDv.push(validBidRequests[i].placementCode);


bid.placementCode has been deprecated, should be replaced with bid.adUnitCode

snapwich · 2017-10-31T20:33:32Z

modules/optimeraBidAdapter.js

+        oDv.push(validBidRequests[i].placementCode);
+      }
+      window.oDv = oDv;
+      var scoresURL = SCORES_BASE_URL + clientID + '/' + optimeraHost + optimeraPathName + '.js';


This looks like JSONP.

1.0 adapters should use AJAX capable endpoints.

For this call, the platform generates a static js file with the JSON set to a var, so there isn't a callback. We are able to parse it from serverRsponse.body in interpretResponse. We were hoping as long as this works ok it would be fine for now until the platform can be updated.

mcallari · 2017-11-02T14:53:59Z

Hi @snapwich, the latest changes have been pushed.

snapwich · 2017-11-17T21:44:25Z

modules/optimeraBidAdapter.js

+      for (var i = 0; i < validBidRequests.length; i++) {
+        oDv.push(validBidRequests[i].adUnitCode);
+      }
+      window.oDv = oDv;


If your adapter is dependent on this global, then your adapter will not work with concurrent auctions (which is a requirement of 1.0).

No problem. This is out and we can do it elsewhere.

snapwich

LGTM, probably needs another review though

matthewlane

One change requested. Also, when testing this locally and on your test page, getting a 403 (Forbidden) response from the SCORES_BASE_URL -- is this still the right endpoint for your adapter?

matthewlane · 2017-12-04T22:31:22Z

modules/optimeraBidAdapter.js

+          dealId = scores[validBids[i].adUnitCode];
+        }
+        var bidResponse = {
+          bidderCode: spec.code,


bidderCode will be set automatically by bidderFactory now, this line can be dropped

@matthewlane ok, I removed the bidderCode. Yes, that endpoint is correct, we just had an error and that has been restored. The Travis build failed, but passes on my local. Can you rerun the build? Thank you.

matthewlane · 2017-12-05T23:08:09Z

modules/optimeraBidAdapter.js

+  interpretResponse: function (serverResponse, bidRequest) {
+    var scores = serverResponse.body.replace('window.oVa = ', '');
+    scores = scores.replace(';', '');
+    scores = JSON.parse(scores);


Any JSON.parse calls will need to be in a try/catch block

mkendall07 · 2017-12-06T00:04:15Z

modules/optimeraBidAdapter.js

+        }
+        var bidResponse = {
+          requestId: validBids[i].bidId,
+          ad: '<div></div>',


this might have been mentioned before, but how do you render the ad if there is no ad content?

hey @mkendall07, we are just creating this adpator to add visibility scores for the ad divs that will be added to DFP calls.

Ok but what does a publisher do with that information? And why is a request to your endpoint required to calculate viewability?

kcandiotti · 2017-12-06T02:28:24Z

@mkendall07 Hi there. We are building this adapter specifically for a use case that a client wanted. Our technology is a targeting tech that normally pushes data directly into DFP in the header. We are utilizing prebid as a way to push data points into DFP so the client does not need to change their hardcode in order to work with us. The client will already know what to do with this data in their ad platform because of our preexisting relationship.

mkendall07 · 2017-12-06T19:50:48Z

@kcandiotti
Thanks for the information.

Due to the reliance on an external script, we aren't going to accept this adapter into the 1.0 version of prebid.

We will be publishing some guidelines about how you can include open source external resource dependencies in just a bit. Once that is out, you can resubmit the adapter. Thanks for your patience.

Optimera Adapter for 1.0 (prebid#1759)

9fc81d2

kcandiotti mentioned this pull request Oct 24, 2017

Adding Optimera Bid Adapter #1617

Closed

9 tasks

mjacobsonny added the Prebid 1.0 label Oct 24, 2017

snapwich self-assigned this Oct 25, 2017

snapwich self-requested a review October 25, 2017 15:48

snapwich requested changes Oct 31, 2017

View reviewed changes

mcallari added 2 commits November 1, 2017 15:06

Merge branch 'master' of github.com:prebid/Prebid.js

fc18cc4

Optimera adapter var checks and assertions (prebid#1759)

a0d99c5

rmloveland mentioned this pull request Nov 7, 2017

Optimera - New Bidder + New Bidder Params prebid/prebid.github.io#375

Closed

mkendall07 added the needs review label Nov 7, 2017

ndhimehta added the ready label Nov 8, 2017

snapwich requested changes Nov 17, 2017

View reviewed changes

Optimera adaptor removing window global (prebid#1759)

a7dee85

snapwich approved these changes Dec 1, 2017

View reviewed changes

matthewlane added LGTM and removed needs review labels Dec 2, 2017

matthewlane self-requested a review December 2, 2017 00:33

matthewlane reviewed Dec 4, 2017

View reviewed changes

Optimera adaptor removing bidderCode property. (prebid#1759)

54cd78f

matthewlane reviewed Dec 5, 2017

View reviewed changes

mkendall07 reviewed Dec 6, 2017

View reviewed changes

mkendall07 closed this Dec 6, 2017

ndhimehta removed the ready label Dec 6, 2017

mcallari mentioned this pull request Dec 14, 2017

Optimera Adapter for 1.0. #1961

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimera Adapter for 1.0 (#1759) #1760

Optimera Adapter for 1.0 (#1759) #1760

mcallari commented Oct 24, 2017 •

edited

Loading

snapwich Oct 31, 2017

snapwich Oct 31, 2017

snapwich Oct 31, 2017

snapwich Oct 31, 2017

snapwich Oct 31, 2017

mcallari Nov 1, 2017

mcallari commented Nov 2, 2017

snapwich Nov 17, 2017

mcallari Nov 20, 2017

snapwich left a comment

matthewlane left a comment

matthewlane Dec 4, 2017

mcallari Dec 5, 2017

matthewlane Dec 5, 2017

mkendall07 Dec 6, 2017

mcallari Dec 6, 2017

mkendall07 Dec 6, 2017

kcandiotti commented Dec 6, 2017

mkendall07 commented Dec 6, 2017

Optimera Adapter for 1.0 (#1759) #1760

Optimera Adapter for 1.0 (#1759) #1760

Conversation

mcallari commented Oct 24, 2017 • edited Loading

Type of change

Type of issue

Description

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcallari commented Nov 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snapwich left a comment

Choose a reason for hiding this comment

matthewlane left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcandiotti commented Dec 6, 2017

mkendall07 commented Dec 6, 2017

mcallari commented Oct 24, 2017 •

edited

Loading