Somo Audience Prebid module. #1833
Conversation
There was a problem hiding this comment.
@eliter Thanks for submitting adapter.
For some reason travis checks did not run. Your code is having linting errors. Please run command gulp lint for details.
Also i am not able to validate test params given in md file. Please test your params with https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/hello_world.html page.
modules/somoaudienceBidAdapter.js
Outdated
| } | ||
| } | ||
|
|
||
| function getReferrer() { |
There was a problem hiding this comment.
This can be removed and you can use utils.getTopWindowReferrer https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L181
modules/somoaudienceBidAdapter.js
Outdated
| } | ||
|
|
||
| function openRtbRequest(bidRequest) { | ||
| logError('openRtbRequest', 'ERROR', bidRequest); |
There was a problem hiding this comment.
What is the purpose of logError here ?
modules/somoaudienceBidAdapter.js
Outdated
| ttl: 360, | ||
| creativeId: bidData.crid, | ||
| creative_id: bidData.crid, | ||
| ad_id: bidId, |
There was a problem hiding this comment.
Why the same key is used multiple times adId, ad_id and adid ?
modules/somoaudienceBidAdapter.js
Outdated
|
|
||
| aliases: ['somo'], | ||
|
|
||
| supportedMediaTypes: ['banner'], |
There was a problem hiding this comment.
banner is default type. No need to add it.
modules/somoaudienceBidAdapter.js
Outdated
| if(typeof bidRequest != 'undefined' && typeof bidRequest.bidRequest != 'undefined' && typeof bidRequest.bidRequest.bidId != 'undefined') { | ||
| bidId = bidRequest.bidRequest.bidId; | ||
| } | ||
| if (bidResponse) { |
There was a problem hiding this comment.
your check should be bidResponse.body. You will always receive this object https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L284
|
Thank you for the review @jaiminpanchal27. |
modules/somoaudienceBidAdapter.md
Outdated
| bids: [{ | ||
| bidder: 'somoaudience', | ||
| params: { | ||
| placement: '22a58cfb0c9b656bff713d1236e930e8' |
There was a problem hiding this comment.
I think this should be placementId
| @@ -0,0 +1,98 @@ | |||
| import {expect} from 'chai'; | |||
| import {spec} from 'modules/somoaudienceBidAdapter'; | |||
| import bidManager from 'src/bidmanager'; | |||
There was a problem hiding this comment.
This line needs to be removed. We have removed bidManager from prebid-1.0.
|
Thanks again @jaiminpanchal27, I have made the requested changes. |
* Somo Audience Prebid module. * Requested Changes * Requested Changes - Wrong var in Documentation * Requested Change - remove unnecessary import
Type of change
Description of change
Official Somo Audience Adapater
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
[email protected]
official adapter submission
Other information