-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arteebee bidder adapter #1849
Conversation
Document PR has been submitted: |
Bid request using the test parameters is getting a 204 back so I cannot verify ads load correctly. Here's the request that's going out: http://bidder.mamrtb.com/rtb/bid/mock?type=json®ister=0 {
"id":"fa0ddb81-cf63-4de3-b08c-496c01a5dfa6",
"imp":[
{
"id":"2af390820b9459",
"tagid":"div-gpt-ad-1460505748561-0",
"banner":{
"format":[
{
"w":300,
"h":250
},
{
"w":300,
"h":600
}
]
}
}
],
"site":{
"id":"prebidtest",
"page":"http://localhost:9999/integrationExamples/gpt/hello_world.html",
"ref":"",
"publisher":{
"id":"prebidtest",
"domain":"localhost:9999"
}
},
"device":{
"ua":"caller",
"ip":"caller",
"js":1
},
"at":1,
"tmax":3000,
"test":1
} |
Lint has a lot of complaints about indentation and spacing: |
Hi, Mike, The 204 is because our system do not allow with host name localhost, is that possible you can map any valid domain to 127.0.0.1. It should be fine after that. I will look at the lint complains, thanks for pointing it out. Jeff Ye |
Hi, Mike, I have fixed the lint complaint as well. Let me know if any thing need me to do. Thank you very much. Jeff Ye |
I aliased my hostname and the ad loads fine now. Lint issues are also resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (now that lint issues are fixed)
Hi, Mike, I have updated our bidder to accept localhost for test request. So, it should work without mapping to a fake host now. BTW, I didn't see the travis ci build result for this PR, is there any thing I have missed? Thanks. Jeff Ye |
@jeffyecn Then close/re-open the PR. |
try close / re-open to trigger travis-ci build |
Hi, Matt, The travis-ci build is okay now. Thanks, Jeff Ye |
Hi, Mike, not sure if still anything need me to do? Have not seen the LGTM label on this PR yet. :-) Thanks, Jeff Ye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 18fe42d.
* Revert "Postbid bugfix (#1844)" This reverts commit 2e7783a. * Revert "Populate adtypes array (#1862)" This reverts commit 214ba19. * Revert "Pass bidderRequestId parameter in Adform adapter (#1888)" This reverts commit 59800f4. * Revert "Add Arteebee bidder adapter (#1849)" This reverts commit 18fe42d. * Revert "fix linting errors for trailing spaces (#1889)" This reverts commit d41287a. * Revert "Randomize pbjs global name when testing (#1787)" This reverts commit f9cb0dd.
* add arteebee adapter * set log * basic structure * basic structure * send caller as placeholder for ip and user agent * send caller as placeholder for ip and user agent * send caller as placeholder for ip and user agent * first version of adapter * add unit testing for arteebee bid adapter * fix indent * fix lint complain
* Revert "Postbid bugfix (prebid#1844)" This reverts commit 2e7783a. * Revert "Populate adtypes array (prebid#1862)" This reverts commit 214ba19. * Revert "Pass bidderRequestId parameter in Adform adapter (prebid#1888)" This reverts commit 59800f4. * Revert "Add Arteebee bidder adapter (prebid#1849)" This reverts commit 18fe42d. * Revert "fix linting errors for trailing spaces (prebid#1889)" This reverts commit d41287a. * Revert "Randomize pbjs global name when testing (prebid#1787)" This reverts commit f9cb0dd.
Type of change
Description of change
Add a new bidder adapter to connect to arteebee.com
Be sure to test the integration with your adserver using the Hello World sample page.
Contact email: [email protected]
Other information
The document pull request will be submit soon.