Kumma Adapter: size parameter is not mandatory anymore #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Nov 22, 2017
modules/kummaBidAdapter.js
Outdated
| @@ -76,7 +76,7 @@ function impression(slot) { | |||
| }; | |||
| } | |||
| function banner(slot) { | |||
| const size = slot.params.size.toUpperCase().split('X'); | |||
| const size = parseSizesInput(slot.sizes)[0].split('x') || slot.params.size.toUpperCase().split('X'); | |||
There was a problem hiding this comment.
this would never be falesy so the 2nd value would never evaluate.
If that's ok then drop it. otherwise you should handle the other cases properly.
|
Now the size parameter was completely removed |
mkendall07
approved these changes
Nov 27, 2017
jaiminpanchal27
approved these changes
Nov 27, 2017
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* size parameter is not mandatory anymore * removing size parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Size parameter is not mandatory anymore for Kumma adapter
[email protected]