fix bug in UndertoneBidAdapter #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug that caused the page domain to be sent as an array instead of a string. Also added a page url parameter to the request
harpere
previously approved these changes
Jan 12, 2018
|
@omerko there are lint errors that need to be fixed. |
|
@omerko any update here? |
matthewlane
approved these changes
Feb 15, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* fix bug in UndertoneBidAdapter Fix bug that caused the page domain to be sent as an array instead of a string. Also added a page url parameter to the request * fix lint error * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix bug that caused the page domain to be sent as an array instead of a string.
Also added a page url parameter to the API request, this does not affect any user facing API or configuration