added advertiserId and networkId for rubiconBidAdapter #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
requested changes
Jan 31, 2018
modules/rubiconBidAdapter.js
Outdated
| netRevenue: config.getConfig('rubicon.netRevenue') || false | ||
| netRevenue: config.getConfig('rubicon.netRevenue') || false, | ||
| advertiserId: ad.advertiser, | ||
| networkId: ad.network |
There was a problem hiding this comment.
I'd propose that these values get set in a sub-object of the bidResponse. i.e. bidResponse.rp.advertiserId and bidResponse.rp.networkId.
These aren't meant to be values used outside certain RP-specific creative review scenarios.
|
updated. using |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* added advertiserId and networkId for rubiconBidAdapter * move advertiserId and networkId into custom rubicon property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added an
advertiserIdandnetworkIdto rubicon bid response so these values can be picked up by analytics and others interested in this data.