Add adapter for GAMMA SSP #2092
Conversation
|
Docs for Gamma bidder adapter |
mkendall07
requested review from
jsnellbaker
and removed request for
matthewlane
There was a problem hiding this comment.
Hello @gammassp, thank you for submitting this adapter. Overall things seem good, though I did have some points for review (please find them below).
Additionally, can you please add some unit tests for the bidAdapter? If you need further information on this piece of the setup, please take a look at the following link:
http://prebid.org/dev-docs/bidder-adaptor.html#adding-unit-tests
Thanks!
| dealId: serverBid.seatbid[0].bid[0].dealid, | ||
| width: serverBid.seatbid[0].bid[0].w, | ||
| height: serverBid.seatbid[0].bid[0].h, | ||
| mediaType: serverBid.type, |
There was a problem hiding this comment.
this property can be removed
There was a problem hiding this comment.
I was removed mediaType property
modules/gammaBidAdapter.js
Outdated
| * @return boolean True if this is a valid bid, and false otherwise. | ||
| */ | ||
| isBidRequestValid: function(bid) { | ||
| return !!(bid.params.siteId || bid.params.zoneId || bid.params.gaxDomain); |
There was a problem hiding this comment.
Is the gaxDomain something you want to always specify within the params object? Is this value going to change often? Other adapters typically setup their own variable for this type of data point in the adapter file so that it's just innately available, so wanted to confirm here.
There was a problem hiding this comment.
The gaxDomain is endpoint domain, it's required and we do not change often.
There was a problem hiding this comment.
Hi @gammassp,
In that case - wouldn't it be more ideal/convenient to have the endpoint incorporated into your adapter's code directly rather than rely on it be passed from the param object? It would be one less thing to maintain/verify within your code, as you would always know what the value would be.
There was a problem hiding this comment.
Hi @jsnellbaker,
The gaxDomain param was removed and moved into adapter, please review again.
Thanks so much
removed mediaType in bid and return vastXml property if video request
|
Hi @jsnellbaker, I have just commited Unit test spec and updated adapter, please review again. Thanks a lot |
* commit gamma adapter * Fixed The Travis CI build failed * fix interpretResponse return empty when server response empty * removed mediaType removed mediaType in bid and return vastXml property if video request * fixed Travis CI build * Travis CI build * add gamma spec * fixed Travis CI build * fix spec * fix spec * Add files via upload * Add files via upload * fix spec * fix Travis CI build * move to module * remove gaxDomain param and move to adapter * remove check isBidRequestValid for gaxDomain * remove gaxDomain param * remove gaxDomain param * remove gaxDomain param * Delete gammaBidAdapter_spec.js
Type of change
Description of change
Added HB adapter for Gamma SSP following Prebid.js 1.0