Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bidderCode for DAN Marketplace Bid Adapter #2183

Merged
merged 5 commits into from
Feb 23, 2018
Merged

Change bidderCode for DAN Marketplace Bid Adapter #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58dae9f
Make Bid Adapter for Dentsu Aegis Network Marketplace
danmarketplace Dec 20, 2017
bd97ba9
Merge remote-tracking branch 'upstream/master'
danmarketplace Feb 1, 2018
2333886
Update DAN_Marketplace adapter
danmarketplace Feb 1, 2018
45714b7
Merge remote-tracking branch 'upstream/master'
danmarketplace Feb 22, 2018
1579d46
Rename danmarketplaceBidAdapter into danmarketBidAdapter
danmarketplace Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/danmarketplaceBidAdapter.js → modules/danmarketBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as utils from 'src/utils';
import {registerBidder} from 'src/adapters/bidderFactory';
const BIDDER_CODE = 'danmarketplace';
const BIDDER_CODE = 'danmarket';
const ENDPOINT_URL = '//ads.danmarketplace.com/hb';
const TIME_TO_LIVE = 360;
const ADAPTER_SYNC_URL = '//ads.danmarketplace.com/push_sync';
Expand All @@ -24,7 +24,7 @@ const LOG_ERROR_MESS = {
export const spec = {
code: BIDDER_CODE,

aliases: ['DANMarketplace', 'DAN_Marketplace'],
aliases: ['DANMarketplace', 'DAN_Marketplace', 'danmarketplace'],

isBidRequestValid: function(bid) {
return !!bid.params.uid;
Expand Down
4 changes: 2 additions & 2 deletions modules/danmarketplaceBidAdapter.md → modules/danmarketBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Module that connects to DAN Marketplace demand source to fetch bids.
sizes: [[300, 250]],
bids: [
{
bidder: "danmarketplace",
bidder: "danmarket",
params: {
uid: '4',
priceType: 'gross' // by default is 'net'
Expand All @@ -28,7 +28,7 @@ Module that connects to DAN Marketplace demand source to fetch bids.
sizes: [[728, 90]],
bids: [
{
bidder: "danmarketplace",
bidder: "danmarket",
params: {
uid: 5,
priceType: 'gross'
Expand Down
24 changes: 12 additions & 12 deletions .../modules/danmarketplaceBidAdapter_spec.js → .../spec/modules/danmarketBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from 'chai';
import { spec } from 'modules/danmarketplaceBidAdapter';
import { spec } from 'modules/danmarketBidAdapter';
import { newBidder } from 'src/adapters/bidderFactory';

describe('DAN_Marketplace Adapter', function () {
Expand All @@ -13,7 +13,7 @@ describe('DAN_Marketplace Adapter', function () {

describe('isBidRequestValid', () => {
let bid = {
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '4'
},
Expand Down Expand Up @@ -41,7 +41,7 @@ describe('DAN_Marketplace Adapter', function () {
describe('buildRequests', () => {
let bidRequests = [
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '5'
},
Expand All @@ -52,7 +52,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1d1a030790a475',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '5'
},
Expand All @@ -63,7 +63,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1d1a030790a475',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '6'
},
Expand Down Expand Up @@ -130,7 +130,7 @@ describe('DAN_Marketplace Adapter', function () {
it('should get correct bid response', () => {
const bidRequests = [
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '4'
},
Expand Down Expand Up @@ -164,7 +164,7 @@ describe('DAN_Marketplace Adapter', function () {
it('should get correct multi bid response', () => {
const bidRequests = [
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '4'
},
Expand All @@ -175,7 +175,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1fa09aee5c8c99',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '5'
},
Expand All @@ -186,7 +186,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1fa09aee5c8c99',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '4'
},
Expand Down Expand Up @@ -244,7 +244,7 @@ describe('DAN_Marketplace Adapter', function () {
it('handles wrong and nobid responses', () => {
const bidRequests = [
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '6'
},
Expand All @@ -255,7 +255,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1fa09aee5c84d34',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '7'
},
Expand All @@ -266,7 +266,7 @@ describe('DAN_Marketplace Adapter', function () {
'auctionId': '1fa09aee5c84d34',
},
{
'bidder': 'danmarketplace',
'bidder': 'danmarket',
'params': {
'uid': '8'
},
Expand Down