Update Yieldlab adapter and add official maintainer #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yieldlab auctions are valid for 5 minutes and not 10. A delivery of an adtag would lead to a new auction after the 5 minute expiration time.
Did stands for demandId which is not a default and not a good identifer for deals. We should use pid (partnershipId) here as a unique identifer for a connection between supply and demand (including deals).
The adsize of a video placement can have a lot of different adsizes and is never "1x1".
Platform Lunar and Yieldlab agree that the Adapter should be offically maintained by Yieldlab.
Campaigns set up in Yieldlab's test network to deliver all the time.
To make it less confusing for customers, we should use the actual naming used in our systems for the params used.
harpere
reviewed
Mar 16, 2018
| @@ -67,16 +67,16 @@ export const spec = { | |||
| width: sizes[0], | |||
| height: sizes[1], | |||
| creativeId: '' + matchedBid.id, | |||
| dealId: matchedBid.did, | |||
| dealId: matchedBid.pid, | |||
There was a problem hiding this comment.
May want to add a test that verifies pid is being mapped to dealId as you expect. Would also help verify that this was an intended change!
There was a problem hiding this comment.
Thank you for your comment. I agree and added a commit: 4010d70
There was a problem hiding this comment.
looks good, thx. will get this merged.
harpere
approved these changes
Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Official update from Yieldlab. Many thanks to our friends from Platform Lunar for the work on the adapter.
Bugfixes:
Other:
Changed params to the actual naming used by Yieldlab to avoid confusion from customers. Corresponding Pull Request to the documentation: Update Yieldlab params with new naming prebid.github.io#651
Updated maintainer to be Yieldlab
contact email of the adapter’s maintainer: [email protected]
official adapter submission