-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: vuble adapter handles dealId #2322
Add: vuble adapter handles dealId #2322
Conversation
Hi @Roffray, Can you take a look at this and let me know if there's something I should alter for my setup? Thanks! |
Hi @jsnellbaker, Geoffray |
Hi @mifefr I'm still getting the same response as before. If it helps, below is a copy of the request made by the adapter: |
Sorry, that's my bad. The pub_id was wrong. I changed the pub_id from 3 to 18 in the md file in the MR. It now matches the one in the http://prebid.org/dev-docs/bidders.html page of the website. Geoffray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update to the test params info. I was seeing the video ad deliver fine and the dealId
change was looking good.
* Add: vuble adapter handles dealId * Fix: new publihser id vuble
Type of change
Description of change
The vuble adapter now handles the dealId returned by the response.