Added bid pool and fixed getAllWinningBids function #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bids # Conflicts: # src/prebid.js
mkendall07
reviewed
Apr 2, 2018
src/targeting.js
Outdated
|
|
||
| const MAX_DFP_KEYLENGTH = 20; | ||
| const TTL_BUFFER = 200; |
mkendall07
requested changes
Apr 2, 2018
mkendall07
added
the
needs 2nd review
mkendall07
approved these changes
Apr 3, 2018
snapwich
approved these changes
Apr 9, 2018
src/auction.js
Outdated
| @@ -197,8 +197,8 @@ export function newAuction({adUnits, adUnitCodes, callback, cbTimeout, labels}) | |||
| executeCallback, | |||
| callBids, | |||
| bidsBackAll, | |||
| setWinningBid: (winningBid) => { _winningBid = winningBid }, | |||
| getWinningBid: () => _winningBid, | |||
| setWinningBid: (winningBid) => { _winningBids = _winningBids.concat(winningBid) }, | |||
There was a problem hiding this comment.
Seems addWinningBid is a more apt name now.
src/auction.js
Outdated
| setWinningBid: (winningBid) => { _winningBid = winningBid }, | ||
| getWinningBid: () => _winningBid, | ||
| setWinningBid: (winningBid) => { _winningBids = _winningBids.concat(winningBid) }, | ||
| getWinningBid: () => _winningBids, |
|
Docs PR here prebid/prebid.github.io#700 |
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Created bid pool, fixed getAllWinningBids and added new api getAllPrebidWinningBids * Updated ttl buffer to 1000 * updated function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR adds bid pool concept to prebid.js
In case of concurrent auctions, auctionManager can have multiple bids from same bidder for a particular adUnit. While selecting bids to do auction, prebid.js uses following criteria if such multiple bids are found.
ttlis not expired. Here buffer of2001000 ms is included in check.Also added new api function
getAllPrebidWinningBidswhich will return the bids won in prebid auction but not rendered by dfp.Also fixed the bug in
getAllWinningBidsdescribed here #2238