Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubicon Adapter - Multiple media types bug fix #2347

Merged
merged 7 commits into from
Apr 10, 2018
Merged

Rubicon Adapter - Multiple media types bug fix #2347

merged 7 commits into from
Apr 10, 2018

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Apr 4, 2018 •
edited
Loading

Type of change

  • Bugfix

Description of change

Rubicon Bid Adapter not handling multiple mediaTypes correctly

  • test parameters for validating bids
{
    code: 'test_div_1',
    sizes: [[728, 90], [300, 250], [300, 600]],
    mediaTypes: {
    "video":
    {"context": "outstream"},
    "banner":
    {"sizes": [[728, 90], [300, 250], [300, 600], [160, 600]]},
    "native": {}},
    bids:
        [
            {
                "bidder": "rubicon",
                "params": {
                    "accountId": 1001,
                    "siteId": 113932,
                    "zoneId": 535510
                }
            },
            {
                "bidder": "appnexus",
                "params": {
                    "placementId": "10433394",
                    "video": {
                        "playback_method": [
                            "auto_play_sound_off"
                        ],
                        "skippable": true
                    }
                }
            }
        ]
}

Other information

https://jira.rubiconproject.com/browse/HB-2441

@idettman idettman requested a review from snapwich April 4, 2018 17:37
snapwich
snapwich approved these changes Apr 10, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit d8a81fc into prebid:master Apr 10, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@idettman @dluxemburg
Rubicon Adapter - Multiple media types bug fix (prebid#2347)
81857d1 
* Removed validation for video mediaTypes; unsupported/malformed video mediaTypes fallback to banner type

* Updated warning text for mediaTypes actions

* Linting fixes

* Added validation for mediaTypes requiring a banner property if video is malformed to fallback without invalidating

* fixed typo and some spacing

* Added invalidation case for invalid legacy video definition

* Linting fix for space after comma in spec file
@idettman idettman deleted the HB-2441-multiple-mediaTypes-bugfix branch March 18, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
adapter support bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idettman @snapwich @mkendall07