Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial VIS.X Bidder Adapter commit #2359

Merged
merged 1 commit into from Apr 16, 2018
Merged

Initial VIS.X Bidder Adapter commit #2359

merged 1 commit into from Apr 16, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2018

Type of change

  • New bidder adapter

Description of change

Adding YOC's VIS.X bidder adapter for Prebid.js.

  • test parameters for validating bids
{
   bidder: 'visx',
   params: {
       uid: '903536'
   }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • done

  • contact email of the adapter’s maintainer: [email protected]

  • official adapter submission

Other information

@snapwich snapwich assigned snapwich and ndhimehta and unassigned snapwich Apr 10, 2018
@ghost
Copy link
Author

ghost commented Apr 13, 2018

@snapwich @ndhimehta

Hey, do you have any updates for us? Our publishers are eagerly awaiting for the new adapter.
Best regards.

@snapwich snapwich self-requested a review April 16, 2018 15:27
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit fa6e221 into prebid:master Apr 16, 2018
@ghost
Copy link
Author

ghost commented Apr 16, 2018

Thanks a lot!

ArmandChoy pushed a commit to RockYou-Ads/Prebid.js that referenced this pull request Apr 18, 2018
* 'master' of https://github.com/prebid/Prebid.js: (211 commits)
  Increment Pre Version
  Prebid 1.8.0 Release
  Make eslint aware of the custom import paths (prebid#2292)
  send travis-ci notifications to slack (prebid#2404)
  send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351)
  convert AN bid params to underscore formatting for pbs (prebid#2385)
  EbdrAdapter add usersync  (prebid#2407)
  Add outstream renderer to Beachfront adapter (prebid#2403)
  Add analytics adapter by Sigmoid (prebid#2316)
  deprecate loadScript and add loadExternalScript (prebid#2391)
  Removed the ability for to override any standard query parameters (prebid#2402)
  Unit test failures (prebid#2405)
  Add Unruly Bid Adapter (prebid#2326)
  Added VIS.X Bidder Adapter (prebid#2359)
  Smart: Add prebid version in the data payload (prebid#2394)
  add support for video bids to use an impression tracking URL  (prebid#2365)
  Create rtbdemandAdkBidAdapter_spec.js (prebid#2352)
  Widespace adapter (prebid#2283)
  Add: Vuble Analytics Adapter (prebid#2331)
  fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363)
  ...

# Conflicts:
#	test/spec/modules/rockyouBidAdapter_spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants