Add New Adapter dgadsBidAdapter

[r-sato]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• test parameters for validating bids

{
  bidder: 'dgads',
  params: {
    location_id: '1',
    site_id: '1';
}

• contact email of the adapter’s maintainer:[email protected]
• official adapter submission
• A link to a PR on the docs repo at Adding dgads bidder dev docs prebid.github.io#714

[jsnellbaker]

Hello @r-sato thanks for submitting this new adapter.

Overall the code looks to be good, except for a few things. See the areas below for the code-specific feedback.

In terms of the testing, I was having some trouble getting the test banner unit to render on the hello_world.html page. The bidResponse seemed fine but the rendering just didn't happen. Was this working for you on the hello_world page?

Please let me know when you get the chance.

[jsnellbaker]

Can you remove this semi-colon?

[r-sato]

Thank you. We corresponded.

[jsnellbaker]

Somewhere in here I would recommend to set the bid's mediaType to native.

When I was testing the native ad with the .md file's test params, the bid's mediaType was set to the default banner.

[r-sato]

Thank you. We corresponded.

[r-sato]

Hi @jsnellbaker, Thank you for the review.
We fixed both and committed.

And regarding hello_world.html,
the image server was down, so we responded.
Please check again.

[jsnellbaker]

Hi @r-sato, thanks for making the changes.

I retested and found the banner creative was showing successfully. However the native test ad wasn't rendering. When I was looking at the browser console to debug the issue, I realized that the pbjs.renderAd function was being invoked - which is normally used for banner or video ads. Native creatives use a different template to render themselves given the variety of creative assets that may/may not be used.

The following page gives an outline of what the native creative code looks like: http://prebid.org/adops/setting-up-prebid-native-in-dfp.html Can you take a look over this page?

[r-sato]

Hi @jsnellbaker, thank you for the check.

Our native ad unit is rendered successfully.
We have registered HTML and CSS with reference to http://prebid.org/adops/setting-up-prebid-native-in-dfp.html.

This is our test html for native.
hello_world_native

Please let me know if anything differs.

[jsnellbaker]

@r-sato Thanks for making the updates and providing the sample test page. Everything looks good now.