Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adform adapter's dynamic price type #2460

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Update adform adapter's dynamic price type #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2d4e86
updated priceType logic
Apr 17, 2018
e3a8ad2
Fix
Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/adformBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,14 @@ export const spec = {
return !!(bid.params.mid);
},
buildRequests: function (validBidRequests) {
var i, l, j, k, bid, _key, _value, reqParams;
var i, l, j, k, bid, _key, _value, reqParams, netRevenue;
var request = [];
var globalParams = [ [ 'adxDomain', 'adx.adform.net' ], [ 'fd', 1 ], [ 'url', null ], [ 'tid', null ], [ 'pt', null ] ];
var netRevenue = 'gross';
var globalParams = [ [ 'adxDomain', 'adx.adform.net' ], [ 'fd', 1 ], [ 'url', null ], [ 'tid', null ] ];
var bids = JSON.parse(JSON.stringify(validBidRequests));
for (i = 0, l = bids.length; i < l; i++) {
bid = bids[i];
if (bid.params.priceType === 'net') {
bid.params.pt = netRevenue = 'net';
if ((bid.params.priceType === 'net') || (bid.params.pt === 'net')) {
netRevenue = 'net';
}
for (j = 0, k = globalParams.length; j < k; j++) {
_key = globalParams[j][0];
Expand All @@ -35,7 +34,8 @@ export const spec = {
}

request.unshift('//' + globalParams[0][1] + '/adx/?rp=4');

netRevenue = netRevenue || 'gross';
request.push('pt=' + netRevenue);
request.push('stid=' + validBidRequests[0].auctionId);

for (i = 1, l = globalParams.length; i < l; i++) {
Expand Down
49 changes: 47 additions & 2 deletions test/spec/modules/adformBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Adform adapter', () => {
it('should pass multiple bids via single request', () => {
let request = spec.buildRequests(bids);
let parsedUrl = parseUrl(request.url);
assert.lengthOf(parsedUrl.items, 5);
assert.lengthOf(parsedUrl.items, 7);
});

it('should handle global request parameters', () => {
Expand Down Expand Up @@ -62,6 +62,7 @@ describe('Adform adapter', () => {
{
mid: '2',
someVar: 'someValue',
pt: 'gross',
transactionId: '5f33781f-9552-4iuy'
},
{
Expand All @@ -78,6 +79,16 @@ describe('Adform adapter', () => {
mid: '3',
pdom: 'home',
transactionId: '5f33781f-9552-7ev3'
},
{
mid: '5',
pt: 'net',
transactionId: '5f33781f-9552-7ev3',
},
{
mid: '6',
pt: 'gross',
transactionId: '5f33781f-9552-7ev3'
}
]);
});
Expand All @@ -87,6 +98,18 @@ describe('Adform adapter', () => {
let request = spec.buildRequests([bids[0]]);
assert.deepEqual(resultBids, bids[0]);
});

it('should set gross to the request, if there is any gross priceType', () => {
let request = spec.buildRequests([bids[5], bids[5]]);
let parsedUrl = parseUrl(request.url);

assert.equal(parsedUrl.query.pt, 'net');

request = spec.buildRequests([bids[4], bids[3]]);
parsedUrl = parseUrl(request.url);

assert.equal(parsedUrl.query.pt, 'gross');
});
});

describe('interpretResponse', () => {
Expand Down Expand Up @@ -178,7 +201,7 @@ describe('Adform adapter', () => {
beforeEach(() => {
let sizes = [[250, 300], [300, 250], [300, 600]];
let placementCode = ['div-01', 'div-02', 'div-03', 'div-04', 'div-05'];
let params = [{ mid: 1, url: 'some// there' }, {adxDomain: null, mid: 2, someVar: 'someValue', pt: 'gross'}, { adxDomain: null, mid: 3, pdom: 'home' }];
let params = [{ mid: 1, url: 'some// there' }, {adxDomain: null, mid: 2, someVar: 'someValue', pt: 'gross'}, { adxDomain: null, mid: 3, pdom: 'home' }, {mid: 5, pt: 'net'}, {mid: 6, pt: 'gross'}];
bids = [
{
adUnitCode: placementCode[0],
Expand Down Expand Up @@ -236,6 +259,28 @@ describe('Adform adapter', () => {
placementCode: placementCode[2],
sizes: [],
transactionId: '5f33781f-9552-7ev3'
},
{
adUnitCode: placementCode[4],
auctionId: '7aefb970-2045',
bidId: '2a0cf6n',
bidder: 'adform',
bidderRequestId: '1ab8d9',
params: params[3],
placementCode: placementCode[2],
sizes: [],
transactionId: '5f33781f-9552-7ev3'
},
{
adUnitCode: placementCode[4],
auctionId: '7aefb970-2045',
bidId: '2a0cf6n',
bidder: 'adform',
bidderRequestId: '1ab8d9',
params: params[4],
placementCode: placementCode[2],
sizes: [],
transactionId: '5f33781f-9552-7ev3'
}
];
serverResponse = {
Expand Down