Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonobi Adapter - Added debugging and analytics query params. #2463

Merged
merged 10 commits into from
Apr 30, 2018

Conversation

JonGoSonobi
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

No documentation change necessary.
Added extra parameters for debugging and analytics purposes.
Fixed issue where sonobi adapter might make a bid request with an empty key_maker object.

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 9ac6ddd into prebid:master Apr 30, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
…2463)

* added vp param to trinity request

* added lib_name and lib_v to trinity

* return null from buildRequests if there is no keymakers

* added test case for empty keymaker

* only importing functions we need from utils

* changed window.pbjs.version to use the gulp repalced macro .version$

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* fixed lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants