-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Platformio Adapter #2468
Conversation
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
Update platformioBidAdapter
Endpoint URL change
Endpoint URL change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @varashellov, the changes to the files look good to me. If you are going to support additional fields in your params, can you please update the platformioBidAdapter.md
file in this repo and your bidders page in the docs repo? Thanks.
Hi @jsnellbaker, thanks for the quick response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add PlatformioBidAdapter * Update platformioBidAdapter.js * Add files via upload * Update hello_world.html * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update hello_world.html * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update hello_world.html * Add files via upload * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Update platformioBidAdapter * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js Endpoint URL change * Update platformioBidAdapter_spec.js Endpoint URL change * Update platformioBidAdapter_spec.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.md * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.md * Update platformioBidAdapter.md * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.md * Add files via upload * Add files via upload * Delete hello_world.html * Add files via upload * Add files via upload * Add files via upload * Add files via upload
Type of change
Description of change
Added to request:
Be sure to test the integration with your adserver using the Hello World sample page.
[email protected]
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information