-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widespace GDPR consent management #2638
Widespace GDPR consent management #2638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mizmaar3 Please see question below.
const { gdprApplies, consentString, vendorData } = bidderRequest.gdprConsent; | ||
const hasGlobalScope = vendorData && vendorData.hasGlobalScope; | ||
data.gdprApplies = gdprApplies ? 1 : gdprApplies === undefined ? '' : 0; | ||
data.gdprConsentData = consentString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of a timeout some pubs may choose to proceed with the auction, but the consentString
would be undefined
in this case. Given the fallbacks you implemented for the other fields if they were undefined
, did you want to leave this field as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because I want undefined
if there is no value so I can remove this value from data object before server call. see line 116 where I remove all keys from data object which has value as undefined or empty string.
For other values i.e. gdprApplies
if it is true I want it as integer 1
if its undefined
I dont want it false but rather '' empty string so I remove this value before sending to server instead of sending false
or undefined
to server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the confirmation.
Type of change
Description of change
Widespace Adapter GDPR consent complaint added
contact email of the adapter’s maintainer
-- [email protected]
[ x] official adapter submission
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
-- Widespace GDPR support variable prebid.github.io#803