Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widespace GDPR consent management #2638

Merged

Conversation

mizmaar3
Copy link
Contributor

Type of change

  • Feature
  • Other - GDPR consent

Description of change

Widespace Adapter GDPR consent complaint added

  • test parameters for validating bids
/** bid params **/
{
  bidder: 'widespace',
  params: {
   sid: '7b6589bf-95c8-4656-90b9-af9737bb9ad3',
   currency: 'EUR'
  }
}

/** Please append a hash parameter `#WS_DEBUG_FORCEADID=23456` to the test page url to always get a test ad  **/ 

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mizmaar3 Please see question below.

const { gdprApplies, consentString, vendorData } = bidderRequest.gdprConsent;
const hasGlobalScope = vendorData && vendorData.hasGlobalScope;
data.gdprApplies = gdprApplies ? 1 : gdprApplies === undefined ? '' : 0;
data.gdprConsentData = consentString;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of a timeout some pubs may choose to proceed with the auction, but the consentString would be undefined in this case. Given the fallbacks you implemented for the other fields if they were undefined, did you want to leave this field as is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I want undefined if there is no value so I can remove this value from data object before server call. see line 116 where I remove all keys from data object which has value as undefined or empty string.

For other values i.e. gdprApplies if it is true I want it as integer 1 if its undefined I dont want it false but rather '' empty string so I remove this value before sending to server instead of sending false or undefined to server

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation.

@jsnellbaker jsnellbaker added LGTM and removed question labels May 29, 2018
@jsnellbaker jsnellbaker merged commit d881ecd into prebid:master May 29, 2018
@anniewalter anniewalter deleted the Widespace_GDPR_Consent_Management branch February 20, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants