new TapHype bidder adapter #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first commit * added unit test cases for TTD id
* changed adapter to support video and display for ad unit * added case for sbi_ct outstream * outstream is display media type
|
Docs PR prebid/prebid.github.io#1045 |
According to documentation, iframes should be inserted at bottom of head, rather than at top.
…mentById(), fix JSDocs in utils.js (prebid#3333) * check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message
jaiminpanchal27
requested changes
Nov 27, 2018
* removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests * changed creativeId to be a Triplelift specific id rather than represent SRA impression * error-proofed creative id
removed `supportedMediaTypes` and logging
remove mediaTypes import
removed `supportedMediaTypes` and logging
remove mediaTypes import
|
Made those changes but was getting a new failing test that was outside my code. Rebased and pushed and it works – I hope this was the right protocol. |
jaiminpanchal27
approved these changes
Dec 3, 2018
loic-talon
pushed a commit
to onfocusio/Prebid.js
that referenced
this pull request
Dec 19, 2018
* new TapHype bidder adapter * Added 930x600 to Rubicon Adapter (prebid#3323) * PubMatic adapter to support TTD (prebid#3311) * first commit * added unit test cases for TTD id * Sonobi - support video and display same adunit (prebid#3325) * changed adapter to support video and display for ad unit * added case for sbi_ct outstream * outstream is display media type * Fix user-sync iframes insertion bug (prebid#3300) According to documentation, iframes should be inserted at bottom of head, rather than at top. * Prevent 33Across adapter from throwing an error when unable to getElementById(), fix JSDocs in utils.js (prebid#3333) * check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * TripleliftBidAdapter-update creative_id (prebid#3324) * removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests * changed creativeId to be a Triplelift specific id rather than represent SRA impression * error-proofed creative id * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import * new TapHype bidder adapter * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* new TapHype bidder adapter * Added 930x600 to Rubicon Adapter (prebid#3323) * PubMatic adapter to support TTD (prebid#3311) * first commit * added unit test cases for TTD id * Sonobi - support video and display same adunit (prebid#3325) * changed adapter to support video and display for ad unit * added case for sbi_ct outstream * outstream is display media type * Fix user-sync iframes insertion bug (prebid#3300) According to documentation, iframes should be inserted at bottom of head, rather than at top. * Prevent 33Across adapter from throwing an error when unable to getElementById(), fix JSDocs in utils.js (prebid#3333) * check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * TripleliftBidAdapter-update creative_id (prebid#3324) * removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests * changed creativeId to be a Triplelift specific id rather than represent SRA impression * error-proofed creative id * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import * new TapHype bidder adapter * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* new TapHype bidder adapter * Added 930x600 to Rubicon Adapter (prebid#3323) * PubMatic adapter to support TTD (prebid#3311) * first commit * added unit test cases for TTD id * Sonobi - support video and display same adunit (prebid#3325) * changed adapter to support video and display for ad unit * added case for sbi_ct outstream * outstream is display media type * Fix user-sync iframes insertion bug (prebid#3300) According to documentation, iframes should be inserted at bottom of head, rather than at top. * Prevent 33Across adapter from throwing an error when unable to getElementById(), fix JSDocs in utils.js (prebid#3333) * check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * TripleliftBidAdapter-update creative_id (prebid#3324) * removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests * changed creativeId to be a Triplelift specific id rather than represent SRA impression * error-proofed creative id * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import * new TapHype bidder adapter * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New TapHype bidder adapter