replaced deprecated getWindowTopLocation with refererInfo.referer #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 3a773e5 into c7b060b - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
@bansawbanchee Failed due to lint error. Please fix |
Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
|
@jaiminpanchal27 linting fixed. please re-review when you get the chance. |
jaiminpanchal27
approved these changes
Nov 30, 2018
loic-talon
pushed a commit
to onfocusio/Prebid.js
that referenced
this pull request
Dec 19, 2018
…ebid#3332) * replaced deprecated getWindowTopLocation with refererInfo.referer * Removed unused import and unnecessary reassign * Rename variable bidderRequests to bidderRequest Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…ebid#3332) * replaced deprecated getWindowTopLocation with refererInfo.referer * Removed unused import and unnecessary reassign * Rename variable bidderRequests to bidderRequest Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…ebid#3332) * replaced deprecated getWindowTopLocation with refererInfo.referer * Removed unused import and unnecessary reassign * Rename variable bidderRequests to bidderRequest Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
replaced deprecated getWindowTopLocation with refererInfo.referer