-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user sync pixel logic in Adtelligent adapter #3359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeneGenie The new code looks good.
However can you please put together some unit tests to support this new code? With this addition, the code-coverage for the adapter file is at 70%; it should be at least 80%.
We should be good once this is added.
…elligentAddSyncs
@jsnellbaker I would be glad to do this, but are failing with this trail :(
BUT! UP: downgraded global |
@GeneGenie Did you install/setup |
Just saw your updates; can you copy the full |
Where adtelligentBidAdapter_spec.js:1 is: |
@GeneGenie Thanks for providing the output; this type command isn't possible anymore due to the You'll either have to run the full You'll have to remove this reference when you want to commit the changes, but it can be used while you're putting the tests together. |
Thank you for help! |
@jsnellbaker Tests were added to get through min required lvl =) |
* Add user sync pixel logic in Adtelligent adapter * Add gdpr support * Add gdpr support * Update tests
* Add user sync pixel logic in Adtelligent adapter * Add gdpr support * Add gdpr support * Update tests
* Add user sync pixel logic in Adtelligent adapter * Add gdpr support * Add gdpr support * Update tests
Description of change
Adding cookie sync pixel support for Adtelligent adapter
Adding gdpr data support
Related PRs:
Misc