Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX Adapter - support User ID module #3529

Merged
merged 9 commits into from
May 1, 2019
Merged

OpenX Adapter - support User ID module #3529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
992534e
added universal id support to bid adapter
Jan 23, 2019
3c56ee6
added unit test for universal id support in bid adapter
Jan 23, 2019
6e95aaa
added universal id support to bid adapter
Jan 23, 2019
8104f11
added unit test for universal id support in bid adapter
Jan 23, 2019
c2bb807
renamed universalID to userId
Feb 7, 2019
58e1a93
Merge remote-tracking branch 'origin/openx-adapter-universal-id-suppo…
Feb 7, 2019
aef78a4
removed merge mistake
Feb 7, 2019
77973fa
fix old code in test
Feb 7, 2019
68ce95b
Merge branch 'master' of https://github.com/prebid/Prebid.js into ope…
Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/openxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,9 @@ function buildCommonQueryParamsFromBids(bids, bidderRequest) {
}
}

if (bids[0].crumbs && bids[0].crumbs.pubcid) {
if ((bids[0].userId && bids[0].userId.pubcid)) {
defaultParams.pubcid = bids[0].userId.pubcid;
} else if (bids[0].crumbs && bids[0].crumbs.pubcid) {
defaultParams.pubcid = bids[0].crumbs.pubcid;
}

Expand Down
24 changes: 24 additions & 0 deletions test/spec/modules/openxBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,30 @@ describe('OpenxAdapter', function () {
const request = spec.buildRequests(bidRequestsWithPubcid);
expect(request[0].data.pubcid).to.equal('c4a4c843-2368-4b5e-b3b1-6ee4702b9ad6');
});

it('should send a pubcid query param when userId.pubcid is defined in the bid requests', function () {
const bidRequestsWithPubcid = [{
bidder: 'openx',
params: {
unit: '11',
delDomain: 'test-del-domain'
},
userId: {
pubcid: 'c1a4c843-2368-4b5e-b3b1-6ee4702b9ad6'
},
adUnitCode: 'adunit-code',
mediaTypes: {
banner: {
sizes: [[300, 250], [300, 600]]
}
},
bidId: 'test-bid-id-1',
bidderRequestId: 'test-bid-request-1',
auctionId: 'test-auction-1'
}];
const request = spec.buildRequests(bidRequestsWithPubcid);
expect(request[0].data.pubcid).to.equal('c1a4c843-2368-4b5e-b3b1-6ee4702b9ad6');
});
})
});

Expand Down