Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversant Adapter - support User ID module #3533

Merged
merged 9 commits into from
Apr 29, 2019
Merged

Conversant Adapter - support User ID module #3533

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12a296a
added universal id support to bid adapter
Jan 23, 2019
7fa602a
added unit test for universal id support
Jan 23, 2019
f0124f5
added universal id support to bid adapter
Jan 23, 2019
d5b834a
added unit test for universal id support
Jan 23, 2019
333745f
renamed universalId to userId
Feb 7, 2019
82ac12c
Merge remote-tracking branch 'origin/conversant-adapter-universal-id-…
Feb 7, 2019
cb6b453
removed old code from merge mistake
Feb 7, 2019
9f27754
test for unit test
Feb 7, 2019
10ee4b6
Merge branch 'conversant-adapter-universal-id-support' of https://git…
Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/conversantBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export const spec = {
imp.banner = banner;
}

if (bid.crumbs && bid.crumbs.pubcid) {
if (bid.userId && bid.userId.pubcid) {
pubcid = bid.userId.pubcid;
} else if (bid.crumbs && bid.crumbs.pubcid) {
pubcid = bid.crumbs.pubcid;
}

Expand Down
13 changes: 13 additions & 0 deletions test/spec/modules/conversantBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,19 @@ describe('Conversant adapter tests', function() {
expect(payload).to.have.deep.nested.property('user.ext.fpc', 12345);
});

it('Verify User ID publisher commond id support', function() {
// clone bidRequests
let requests = utils.deepClone(bidRequests)

// add pubcid to every entry
requests.forEach((unit) => {
Object.assign(unit, {userId: {pubcid: 67890}});
});
// construct http post payload
const payload = spec.buildRequests(requests).data;
expect(payload).to.have.deep.nested.property('user.ext.fpc', 67890);
});

it('Verify GDPR bid request', function() {
// add gdpr info
const bidRequest = {
Expand Down