Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bid adapter for TheAdx #3547

Merged
merged 2 commits into from
Feb 23, 2019
Merged

New bid adapter for TheAdx #3547

merged 2 commits into from
Feb 23, 2019

Conversation

mustafakemal16
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

New bid adapter for TheAdx

  • test parameters for validating bids
   var adUnits = [{
     code: 'div-gpt-ad-1460505748561-0',
     mediaTypes: {
         banner: {
             sizes: [
                 [300, 250],
                 [300, 600]
             ],
         }
     },
     bids: [{
         bidder: 'theadx',
         params: {
             pid: 1, // publisher id
             wid: 7, // website id
             tagId: 18, //zone id
             url: window.location.href || window.top.location.href
         }
     }]

 }];


Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer

[email protected]

  • [X ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg
Copy link
Collaborator

bretg commented Feb 12, 2019

docs PR prebid/prebid.github.io#1150

@mike-chowla
Copy link
Contributor

The test parameters are not getting a bid back.
I'm seeing a request go out to http://ssp.theadx.com/request?tagid=18 but a zero length response is coming back

modules/theAdxBidAdapter.js Outdated Show resolved Hide resolved
modules/theAdxBidAdapter.js Outdated Show resolved Hide resolved
modules/theAdxBidAdapter.js Outdated Show resolved Hide resolved
modules/theAdxBidAdapter.js Outdated Show resolved Hide resolved
modules/theAdxBidAdapter.js Outdated Show resolved Hide resolved
@mustafakemal16
Copy link
Contributor Author

The test parameters are not getting a bid back.
I'm seeing a request go out to http://ssp.theadx.com/request?tagid=18 but a zero length response is coming back

Hi Mike,
i think, its a domain issue, which domain call to test page? we add test.localhost support. localhost && test.localhost supported in this tag.
best regards

@mike-chowla
Copy link
Contributor

I was able to get a bid using localhost.

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 68dfb64 into prebid:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants