-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon Adapter: Switching Video Endpoint to Rubicon PBS #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/prebidServerBidAdapter/index.js # modules/rubiconBidAdapter.js # test/spec/modules/prebidServerBidAdapter_spec.js # test/spec/modules/rubiconBidAdapter_spec.js
…cludewinners value
…che_path, since the hb_cache_hostpath will be suppressed soon
idettman
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
idettman
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updates LGTM
robertrmartinez
commented
Mar 5, 2019
…thub.com/rubicon-project/Prebid.js into Rubicon_PBS_Video" This reverts commit 712e566, reversing changes made to 4f59e48.
harpere
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Rubicon Project will be switching the endpoint it uses to field Video Ads.
We will now be utilizing our Prebid Server Instance.
Changes publishers should be aware of can be seen here https://github.com/prebid/prebid.github.io/pull/1181/files
Summary of changes:
Rubicon will be requiring a few extra fields (in addition to existing requirement of
playerSize
andcontext
) to be declared in the Top LevelmediaTypes.video
object according to the openRTB2 Spec: https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdfmimes
,protocols
,maxduration
,linearity
, andapi
Rubicon will be utilizing Server Side Caching using Prebid-Cache.
This changes the Cache URL.
Any publishers who have the old
fastlane-adv.rubiconproject.com
endpoint in their DFP will eventually need to have it updated.We have implemented a temporary redirector on that server which will hit Prebid-Cache in order to retrieve your Vast XML.
If you have any issues and or questions. Please feel free to reach out.