Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kargo sizes and full bid request object #3771

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Kargo sizes and full bid request object #3771

merged 1 commit into from
Apr 30, 2019

Conversation

samuelhorwitz
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Adding sizes to our request as well as passing up request raw data for future usage on our server

@samuelhorwitz samuelhorwitz changed the title kargo sizes and full bid request object Kargo sizes and full bid request object Apr 19, 2019
@samuelhorwitz
Copy link
Contributor Author

The tests seem to fail but locally my tests pass, I believe there are failing tests on master looking at the logs

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman added the LGTM label Apr 30, 2019
@idettman idettman merged commit d6eeb31 into prebid:master Apr 30, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants