PubMatic adapter support to read TTD Id from UserId module #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @robertrmartinez , |
robertrmartinez
approved these changes
May 18, 2019
modules/pubmaticBidAdapter.js
Outdated
| let adsrvrOrgId = config.getConfig('adsrvrOrgId'); | ||
| if (adsrvrOrgId && utils.isStr(adsrvrOrgId.TDID)) { | ||
| if (validBidRequests[0] && validBidRequests[0].userId && utils.isStr(validBidRequests[0].userId.tdid)) { |
There was a problem hiding this comment.
Could possibly use utils.deepAccess here instead:
if (utils.isStr(utils.deepAccess(validBidRequests, '0.userId.tdid'))) {
instead of
if (validBidRequests[0] && validBidRequests[0].userId && utils.isStr(validBidRequests[0].userId.tdid)) {
There was a problem hiding this comment.
Won't request changes because of this,
But will wait to merge in case the change is wanted to be made!
Don't worry we will get it in before the release!
There was a problem hiding this comment.
Sure @robertrmartinez , thank you for this suggestion :)
|
@pm-harshad-mane Cool! Thanks :) |
|
Thank you @robertrmartinez !! :) |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* in-dev * added unit test cases * adding isStr check on userId.tdid * review suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
PubMatic adapter support to read TTD Id from UserId module