Use actual global object name in log message #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rooke If we're going to update this log message, there is one other that could be similarly updated; link to area is below: Could you include this change? |
- The global Prebid.js object name can be something other than 'pbjs'. Update log messages to reference the specified prebid global object name.
|
@jsnellbaker Thanks for finding that. |
jsnellbaker
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Jun 5, 2019
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jun 7, 2019
- The global Prebid.js object name can be something other than 'pbjs'. Update log messages to reference the specified prebid global object name.
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
- The global Prebid.js object name can be something other than 'pbjs'. Update log messages to reference the specified prebid global object name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The global Prebid.js object name can be something other than 'pbjs'. Update this log message to reference the specified prebid global object name.