Aardvark adapter, add width & height params #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretg
approved these changes
Jun 12, 2019
|
please open a docs PR for against https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/aardvark.md for the new params. Thanks. |
|
hey @bretg , params I added here are not Bid params, but rather dimensions of the screen that we read every time we |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add width (
w) and height (h) params to aardvarkBidAdapter, that should correspond towindow.top.innerWidthandwindow.top.innerHeightwhenwindow.topis available, otherwise fallback towindow.innerWidthandwindow.innerHeight.Slightly bumped up test coverage percentage of aardvarkBidAdapter.
contact email of the adapter’s maintainer: [email protected]
official adapter submission