Safeframe resize fix #3988
Merged
Safeframe resize fix #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested review from
mkendall07,
jsnellbaker and
robertrmartinez
jsnellbaker
approved these changes
Jul 11, 2019
robertrmartinez
approved these changes
Jul 11, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
This was referenced Oct 8, 2019
|
https://developer.mozilla.org/en-US/docs/Web/CSS/:last-child it looks like last-child isn't supported in safari according to this link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR fixes resizing issue in case of banner safeframe. prebid/prebid-universal-creative#66
When you refresh the ad unit, dfp loads a new div for the creative and marks old div as
to be removed. Prebid core was resizing the div which will be removed once rendering is complete.Tested with DFP and APAS.
Other information
@benjaminclot