Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBJS support for stored responses #4032

Merged
merged 84 commits into from
Jan 28, 2020

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Jul 27, 2019

Type of change

  • Feature

Description of change

Towards utilizing the Stored Response feature described in prebid/prebid-server#861, some changes are needed in PBJS.
The basic idea is to extend the awesome debugging feature already present in PBJS. http://prebid.org/dev-docs/troubleshooting-tips.html#modify-bid-responses-for-testing

Our SE team can add another attribute to the existing debugging object, which will be saved in local storage. The Rubicon and PBS adapters look for debugging storedAuctionResponse property before it sends a video request, passing imp[].ext.prebid.storedauctionresponse.id in the openrtb.

javascript console> pbjs.setConfig({
  debugging: {
    enabled: true,
    bidRequests: [
         {bidder: "rubicon", adUnitCode: "/123", storedAuctionResponse=11111},
         {bidder: "rubicon", adUnitCode: "/456", storedAuctionResponse=22222}
    ]
  }
});

Other information

nakamoto and others added 26 commits February 16, 2019 21:30
# Conflicts:
#	modules/advangelistsBidAdapter.js
#	test/spec/modules/advangelistsBidAdapter_spec.js
@idettman idettman self-assigned this Jul 27, 2019
@idettman idettman assigned harpere and unassigned harpere Dec 4, 2019
@harpere
Copy link
Collaborator

harpere commented Jan 6, 2020

@idettman conflicts need to be fixed.

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good other than the one minor comment and the conflict.

modules/prebidServerBidAdapter/index.js Outdated Show resolved Hide resolved
@idettman idettman requested a review from harpere January 7, 2020 18:10
@idettman idettman removed their assignment Jan 7, 2020
Isaac Dettman added 2 commits January 23, 2020 10:07
…-debug-override-bidrequests

� Conflicts:
�	modules/rubiconBidAdapter.js
�	test/spec/modules/rubiconBidAdapter_spec.js
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to thoroughly test the changes you made in the auction requests, hopefully our tests are good! LGTM

@idettman idettman merged commit 50b7433 into prebid:master Jan 28, 2020
@bretg bretg removed needs 2nd review Core module updates require two approvals from the core team needs docs labels Jan 30, 2020
@robertrmartinez robertrmartinez deleted the add-debug-override-bidrequests branch July 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants