-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBJS support for stored responses #4032
PBJS support for stored responses #4032
Conversation
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
…-debug-override-bidrequests
@idettman conflicts need to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good other than the one minor comment and the conflict.
…-debug-override-bidrequests � Conflicts: � test/spec/auctionmanager_spec.js
…-debug-override-bidrequests � Conflicts: � modules/rubiconBidAdapter.js � test/spec/modules/rubiconBidAdapter_spec.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to thoroughly test the changes you made in the auction requests, hopefully our tests are good! LGTM
Type of change
Description of change
Towards utilizing the Stored Response feature described in prebid/prebid-server#861, some changes are needed in PBJS.
The basic idea is to extend the awesome debugging feature already present in PBJS. http://prebid.org/dev-docs/troubleshooting-tips.html#modify-bid-responses-for-testing
Our SE team can add another attribute to the existing debugging object, which will be saved in local storage. The Rubicon and PBS adapters look for debugging storedAuctionResponse property before it sends a video request, passing
imp[].ext.prebid.storedauctionresponse.id
in the openrtb.Other information