-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon: support SupplyChain (schain) #4315
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8d635ff
Add microadBidAdapter
3055b90
Remove unnecessary encodeURIComponent from microadBidAdapter
67fb91b
Submit Advangelists Prebid Adapter
3ebb916
Submit Advangelists Prebid Adapter 1.1
4f5c451
Correct procudtion endpoint for prebid
2dc6d1d
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
fa3e081
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
600a46e
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge branch 'master' of https://github.com/prebid/Prebid.js
6ce04ab
Merge remote-tracking branch 'upstream/master'
415e2f6
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
61fb82c
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
3cc4c67
analytics update with wrapper name
cd81e02
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
e2b4e04
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
53b5970
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
5c00ed5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
28848ad
reverted error merge
ab635ee
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
93308f5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
1cfd52d
Merge branch 'master' of https://github.com/prebid/Prebid.js
d619807
Merge branch 'master' of https://github.com/prebid/Prebid.js
9893f0f
Merge branch 'master' of https://github.com/prebid/Prebid.js
986a251
Merge remote-tracking branch 'upstream/master'
2cae7c0
Merge branch 'master' of https://github.com/prebid/Prebid.js into ori…
d7fd252
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7c01ba
Merge branch 'master' of https://github.com/prebid/Prebid.js
24a28aa
Merge branch 'master' of https://github.com/prebid/Prebid.js
7a1a4ec
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
4173d16
Merge branch 'master' of https://github.com/prebid/Prebid.js
ca13952
update changed default value of netRevenue to true
0b6cd48
Merge branch 'master' of https://github.com/prebid/Prebid.js
5f0110d
Merge branch 'master' of https://github.com/prebid/Prebid.js
f930a34
Merge remote-tracking branch 'upstream/master'
9bff282
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7ea2eb
Starting schain
tjeastmond aaab6bb
More tests for banner schain support
tjeastmond c42e1fc
Video tests
tjeastmond 71ef8c5
Encoding tweaks, required fields and comments
tjeastmond e18d191
Removed .only() from tests
tjeastmond e0e1300
Change requests per Bret
tjeastmond 0a458a8
Merge branch 'master' into hb-6418-schain
tjeastmond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check occurs on line 460 as well as inside this function.
Is there a specific reason? Think if it is not valid we just do not set the
rp_schain
So seems like this:
if (!supplyChainIsValid) return '';
will never actually be hit right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was that
serializeSupplyChain()
could be used directly from other methods if need be, and to eventually extract that method to a utils lib for other modules to use. I can remove it though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with either way, makes sense if many others will want to use it so we can move it later!