Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GumGum: use mediaTypes.banner.sizes #4416

Merged
merged 7 commits into from
Nov 7, 2019
Merged

GumGum: use mediaTypes.banner.sizes #4416

merged 7 commits into from
Nov 7, 2019

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Nov 4, 2019

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Uses mediaTypes.banner.sizes first before trying bidRequest.sizes for Prebid 3.0 release

@jsnellbaker jsnellbaker self-requested a review November 7, 2019 19:54
@jsnellbaker jsnellbaker self-assigned this Nov 7, 2019
jsnellbaker
jsnellbaker approved these changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 04ba41a into prebid:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susyt @jsnellbaker