Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory id and schain support for display #4426

Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
62516db
outstream changes
Jun 27, 2019
05e333a
removing global filtet
Jun 27, 2019
054b515
reverting page
Jun 27, 2019
94cbc2d
message
Jul 2, 2019
d49e922
adapter change
Jul 3, 2019
7a43143
remove space
Jul 3, 2019
bc859b3
testcases
Jul 3, 2019
0a8a86c
testpage
Jul 3, 2019
22e4ec9
spaces for test page
Jul 3, 2019
9637b48
renderer exist case
Jul 4, 2019
0e2d31b
reverting package-lock.json
Jul 9, 2019
88ac283
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jul 11, 2019
d81769b
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jul 24, 2019
2d48e1e
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 1, 2019
63a37e3
adding schain object
Aug 2, 2019
873a2c1
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 4, 2019
7e68c35
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 7, 2019
e8c40c3
adding tagid
Aug 7, 2019
af32e45
syntaxx error fix
Aug 7, 2019
4bb7c45
video.html
Aug 7, 2019
caf81ac
space trailing
Aug 7, 2019
514f68d
space
Aug 7, 2019
5dc1086
tagid
Aug 7, 2019
606eb96
inventoryId and placement
Aug 14, 2019
4cfb6f4
rewarded video
Sep 3, 2019
e03ff33
added unit test case
Sep 5, 2019
af1f4d4
inventory_id and placement
Sep 9, 2019
270d6e4
removed unnecessary file
Sep 23, 2019
1fa68e4
Merge branch 'master' into Placement-and-Inventory_id
DeepthiNeeladri Oct 22, 2019
8df15d0
lint error
DeepthiNeeladri Oct 22, 2019
2fd0944
Merge branch 'master' into Placement-and-Inventory_id
DeepthiNeeladri Oct 31, 2019
4c93d68
Update oneVideoBidAdapter.js
DeepthiNeeladri Oct 31, 2019
9fd977a
lint error fix
DeepthiNeeladri Oct 31, 2019
47dedc0
supporting inventory object in banner also
Nov 6, 2019
776c81e
test case
Nov 6, 2019
5b7c8f2
test cases
Nov 6, 2019
6f56848
Merge branch 'master' into InventoryId-Support-for-Display
DeepthiNeeladri Nov 6, 2019
c2e3eee
supporting schain
Nov 6, 2019
243ee03
Merge branch 'InventoryId-Support-for-Display' of https://github.com/…
Nov 6, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adapter change
  • Loading branch information
Deepthi Neeladri Sravana authored and Deepthi Neeladri Sravana committed Jul 3, 2019

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit d49e9223c2095088a6c7fdf4945cfba7984d5596
24 changes: 13 additions & 11 deletions modules/oneVideoBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as utils from '../src/utils';
import {registerBidder} from '../src/adapters/bidderFactory';
import { Renderer } from 'src/renderer';

const BIDDER_CODE = 'oneVideo';
export const spec = {
@@ -78,7 +77,8 @@ export const spec = {
requestId: bidRequest.bidId,
bidderCode: spec.code,
cpm: bid.price,
creativeId: bid.id,
adId: bid.adid,
creativeId: bid.crid,
width: size.width,
height: size.height,
mediaType: 'video',
@@ -92,7 +92,7 @@ export const spec = {
} else if (bid.adm) {
bidResponse.vastXml = bid.adm;
}
bidResponse.renderer = (bidRequest.mediaTypes.video.context === 'outstream') ? newRenderer(bidResponse) : undefined;
bidResponse.renderer = (bidRequest.mediaTypes.video.context === 'outstream') ? newRenderer(bidRequest, bidResponse) : undefined;
return bidResponse;
},
/**
@@ -224,14 +224,16 @@ function isSecure() {
* Create oneVideo renderer
* @returns {*}
*/
function newRenderer(bidResponse) {
const renderer = Renderer.install({
url: 'https://cdn.vidible.tv/prod/2019-06/04/5cf5164bc14228000199c0fa_v3.js',
render: function (bidResponse) {
o2PlayerRender(bidResponse);
}
});
return renderer;
function newRenderer(bidRequest, bid) {
if (bidRequest) {
bidRequest.renderer = {};
bidRequest.renderer.url = 'https://cdn.vidible.tv/prod/hb-outstream-renderer/renderer.js';
bidRequest.renderer.render = function(bid) {
setTimeout(function () {
o2PlayerRender(bid);
}, 1000)
};
}
}

registerBidder(spec);