Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubiconBidAdapter_spec.js is using describe.only, stopping other tests from running #4459

Merged
merged 1 commit into from
Nov 12, 2019
Merged

rubiconBidAdapter_spec.js is using describe.only, stopping other tests from running #4459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ export const spec = {
'gdpr',
'gdpr_consent',
'rp_schain',
'rf',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate param

'tpid_tdid',
'tpid_liveintent.com',
'tg_v.LIseg',
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/rubiconBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,7 +2311,7 @@ describe('the rubicon adapter', function () {
});
});

describe.only('Supply Chain Support', function() {
describe('Supply Chain Support', function() {
const nodePropsOrder = ['asi', 'sid', 'hp', 'rid', 'name', 'domain'];
let bidRequests;
let schainConfig;
Expand Down