Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCX adapter: Attaching GDPR Consent Params #4524

Merged
merged 6 commits into from
Dec 31, 2019

Conversation

mjaworskiccx
Copy link
Contributor

Type of change

  • Bugfix
  • [x ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg
Copy link
Collaborator

bretg commented Dec 11, 2019

Unit test(s) please

@bretg bretg changed the title Attaching GDPR Consent Params CCX adapter: Attaching GDPR Consent Params Dec 11, 2019
@bretg
Copy link
Collaborator

bretg commented Dec 11, 2019

docs PR prebid/prebid.github.io#1652

@bretg
Copy link
Collaborator

bretg commented Dec 11, 2019

@mjaworskiccx - please fix conflicts (maybe caused by 3.0?)

@mjaworskiccx
Copy link
Contributor Author

Confict fixed.
Unit test added.

@stale
Copy link

stale bot commented Dec 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested on hello_world page. Looks good.

@sumit116 sumit116 merged commit 8386a33 into prebid:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants