-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-auction filters and pbAdslot support #4539
Conversation
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @idettman - we added in an 'fpd' level at some point that didn't get reflected in pbAdSlot.
Docs PR prebid/prebid.github.io#1728 |
…-pbadslot � Conflicts: � src/adapterManager.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
# Conflicts: # modules/prebidServerBidAdapter/index.js # modules/rubiconBidAdapter.js # test/spec/modules/prebidServerBidAdapter_spec.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tests for this PR are failing
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * add beforeRequestBids event * add pbAdSlot support to pbs adapter * update jsdoc comment for on before request bids event * add pbAdSlot support to rubicon adapter * added more tests * update code comment * add api test, update event to emit from adapterManager * add multi-bid api test * added pbAdSlot to rubicon bid adapter video bid request * added ext to server video path in rp adapter pbAdSlot * fix for pb video ortb path * fix for consistency with pb server * update obj path to fpd.context.pbAdSlot * add leading slash removal to all outputs of pbAslot * revert to previous branch reviewed * revert to previous branch reviewed * fix merge errors (cherry picked from commit fa13966)
* Pre-auction filters and pbAdslot support (#4539) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * add beforeRequestBids event * add pbAdSlot support to pbs adapter * update jsdoc comment for on before request bids event * add pbAdSlot support to rubicon adapter * added more tests * update code comment * add api test, update event to emit from adapterManager * add multi-bid api test * added pbAdSlot to rubicon bid adapter video bid request * added ext to server video path in rp adapter pbAdSlot * fix for pb video ortb path * fix for consistency with pb server * update obj path to fpd.context.pbAdSlot * add leading slash removal to all outputs of pbAslot * revert to previous branch reviewed * revert to previous branch reviewed * fix merge errors (cherry picked from commit fa13966) * updated tests to use server.js for xhr
Type of change
Description of change
Pre-auction filters and pbadslot support
pbAdSlot
attribute is added to the Prebid Ad Unit in the First Party Data contextimp[].ext.context.data.adslot
Other information
#4149