Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate Playground XYZ adapter with v3 support #4585

Merged
merged 5 commits into from
Dec 23, 2019

Conversation

monofonik
Copy link
Contributor

@monofonik monofonik commented Dec 12, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This pull request reinstates the Playground XYZ bid adapter with minor changes to make it compliant with Prebid v3.

I haven't submitted this as a "New bidder adapter" as our test parameters / dev docs remain unchanged.

@monofonik
Copy link
Contributor Author

Note that the failing CircleCI tests appear to be unrelated to this PR

@Fawke Fawke self-assigned this Dec 17, 2019
@Fawke Fawke self-requested a review December 17, 2019 14:11
@monofonik monofonik force-pushed the PT-75-prebid-v3-support branch from 5b69b5a to ce3bdec Compare December 18, 2019 00:11
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monofonik,

Thanks for making your adapter 3.0 compliant.

There are a few issues that I wanted to bring to your notice.

  • Your adapter is failing when I use the hello world example and plug in your given parameters in the md file.

Screenshot 2019-12-18 at 9 14 58 PM

  • Is there any specific reason for modifying appnexusBidAdapter_spec.js

@monofonik monofonik force-pushed the PT-75-prebid-v3-support branch from 2a6a483 to 86ee40a Compare December 18, 2019 21:53
@monofonik
Copy link
Contributor Author

Thanks @Fawke I've addressed the erroneous change to appnexusBidAdapter_spec.js and also corrected our test params with the correct ad unit code.

Can you try the hello world test again? Couple of notes:

  • depending on your geo you may have to increase PREBID_TIMEOUT
  • our bidder wont respond with demand unless it detects a valid hostname, so you may need to e.g. update your hosts file with a dummy domain name pointing to your local machine (see screeny below)

image

@Fawke
Copy link
Contributor

Fawke commented Dec 20, 2019

Hi @monofonik,

Thanks for updating the test parameters, now, am able to get a bid back. While checking the response headers, I noticed that the content-encoding is not set to gzip. We require all our bid adapters to compress the their response before sending it to the client for a better performance.

Is it possible to make this change and send the response gzipped?

@monofonik
Copy link
Contributor Author

Hi @Fawke no problem - confirming our bid responses are now gzipped.

@Fawke
Copy link
Contributor

Fawke commented Dec 23, 2019

@monofonik Thanks for making the change.

@Fawke Fawke merged commit 521c0f9 into prebid:master Dec 23, 2019
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* reinstate playgroundXyz bid adapter with v3 compliance

* parse protocol and hostname from referer before populating payload

* correct erroneous deletion

* updated test parameters for hello world example
@Fawke Fawke added LGTM and removed needs update labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants