-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate Playground XYZ adapter with v3 support #4585
Conversation
Note that the failing CircleCI tests appear to be unrelated to this PR |
5b69b5a
to
ce3bdec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @monofonik,
Thanks for making your adapter 3.0 compliant.
There are a few issues that I wanted to bring to your notice.
- Your adapter is failing when I use the hello world example and plug in your given parameters in the md file.
- Is there any specific reason for modifying appnexusBidAdapter_spec.js
2a6a483
to
86ee40a
Compare
Thanks @Fawke I've addressed the erroneous change to Can you try the hello world test again? Couple of notes:
|
Hi @monofonik, Thanks for updating the test parameters, now, am able to get a bid back. While checking the response headers, I noticed that the content-encoding is not set to gzip. We require all our bid adapters to compress the their response before sending it to the client for a better performance. Is it possible to make this change and send the response gzipped? |
Hi @Fawke no problem - confirming our bid responses are now gzipped. |
@monofonik Thanks for making the change. |
* reinstate playgroundXyz bid adapter with v3 compliance * parse protocol and hostname from referer before populating payload * correct erroneous deletion * updated test parameters for hello world example
Type of change
Description of change
This pull request reinstates the Playground XYZ bid adapter with minor changes to make it compliant with Prebid v3.
I haven't submitted this as a "New bidder adapter" as our test parameters / dev docs remain unchanged.