FreewheelSSP - enable mediaTypes banner and video with test cases

[zhew1118]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

We add support for mediaTypes banner and video. And test cases related.

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
  [email protected]
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[jsnellbaker]

Hi @zhew1118

The changes overall look okay. There was one area I had a question, please see comment below.

Additionally - though I can see you added a few new unit tests, it seems the coverage percentage is still below the accepted range of 80%. On master your adapter is at 87.23%, whereas this PR branch is at 79.23%. I think there are few sections of code that aren't being used now that were before (eg getBiggerSizeWithLimit()) as a result of the new logic/tests.

Can you please take a look at this and try to improve the coverage? If needed, you can gulp test-coverage and gulp view-coverage in your local copy of Prebid.js to see the details on the coverage.

Please let me know if you have any questions. Thanks!

[jsnellbaker]

Can you clarify where the mediaTypes.banner.minSizeLimit and mediaTypes.banner.maxSizeLimit fields get populated? Are those extra fields meant to be added within the adUnit setup or something else?

[zhew1118]

You are right. These two fields could be added within the adUnit set up together with the banner.sizes array. The idea is if any of the two limits (or both) is set, then only valid size within the [minSize -> maxSize] range could be used. If none of the limits are set, the default value of minSize [0, 0] and maxSize [Number.MAX_VALUE, Number.MAX_VALUE] will be set so that all the sizes in the array are treated as potentially valid.

[jsnellbaker]

@zhew1118 Thanks for the clarification and the update. The unit test coverage looks better now.