Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audiencerun bid adapter #4761

Merged
merged 9 commits into from
Jan 31, 2020
Merged

Audiencerun bid adapter #4761

merged 9 commits into from
Jan 31, 2020

Conversation

audiencerun
Copy link
Contributor

@audiencerun audiencerun commented Jan 20, 2020 •
edited
Loading

Type of change

  • New bidder adapter

Description of change

  • New adapter for Audiencerun.com Ad Network
  • test parameters for validating bids
{
  bidder: 'audiencerun',
  params: { 
              zoneId: 'xtov2mgij0'
          }
}

@audiencerun audiencerun mentioned this pull request Jan 20, 2020
Merged
@audiencerun audiencerun marked this pull request as ready for review January 20, 2020 16:37
@harpere harpere requested a review from msm0504 January 22, 2020 17:43
msm0504
msm0504 suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these comments concern use of features that are no longer supported in Prebid 3.

Here's a link to the full list of changes: http://prebid.org/blog/pbjs-3

modules/audiencerunBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/audiencerunBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/audiencerunBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/audiencerunBidAdapter.js Show resolved Hide resolved
modules/audiencerunBidAdapter.js Outdated Show resolved Hide resolved
modules/audiencerunBidAdapter.js Show resolved Hide resolved
@audiencerun audiencerun requested a review from msm0504 January 29, 2020 17:34
msm0504
msm0504 suggested changes Jan 29, 2020
View reviewed changes
modules/audiencerunBidAdapter.js Outdated Show resolved Hide resolved
@msm0504 msm0504 added LGTM and removed needs update labels Jan 30, 2020
msm0504
msm0504 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audiencerun
Copy link
Contributor Author

Thank's for you review msm0504
Do you need anything else to validate?

@msm0504 msm0504 merged commit 613b99b into prebid:master Jan 31, 2020
@msm0504
Copy link
Contributor

msm0504 commented Jan 31, 2020

@audiencerun No, I don't need anything else. This will be in the next Prebid release

hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
@audiencerun @hellsingblack
Audiencerun bid adapter (prebid#4761)
edc687f 
* New adapter AudienceRun

* Fix issues AudiencerunAdapter

* Fix issues AudiencerunAdapter

* Fix issues AudiencerunAdapter

* Fix issues AudiencerunAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msm0504 msm0504 msm0504 approved these changes

Assignees

@msm0504 msm0504

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@audiencerun @msm0504 @harpere