-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the audience network adapter to be 3.x compliant #4769
Conversation
@lovell - we'd like you to have a chance to review and approve this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the gist with the diffs.
I tested the 2.x Request: 3.x Request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going ahead to merge this as many are waiting on it. The testing done looks reasonable to me. @lovell , we'd still invite you to review the change. |
Thanks for restoring this adapter. There's a new version coming along soon but this will provide a stopgap for those wanting to use it with Prebid.js v3. |
Adding back the audience network adapter and updating it to be compliant on 3.x.
You can see a diff from the 2.x and 3.x versions at the revision history of this GIST:
https://gist.github.com/robertrmartinez/cc4cc72fd1445f0096775aac36305583/revisions